-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 마이페이지 기능을 일부 구현한다 #25 #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요!! 양이 엄청 많은데 알아보기 쉽게 너무 잘 짜신거 같습니다
@@ -21,4 +21,11 @@ List<Quiz> findAllByLearningSetAndLevel( | |||
@Param("learningSet") LearningSet learningSet, @Param("level") Level level); | |||
|
|||
List<Quiz> findAllByPurpose(Purpose purpose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 querydsl로 작성하면 어떠세요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 좋습니다 수정할게요!
@Repository | ||
public interface ConceptScrapRepository | ||
extends JpaRepository<ConceptScrap, Long>, ConceptScrapRepositoryCustom { | ||
Boolean existsByConcept_ConceptIdAndUserId(Long conceptId, Long userId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 혹시 _ 쓰신 이유 알수 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept클래스의 id가 conceptId로 되어있어서 existByConceptIdAndUserID 이거로는 조회가 안되더라구요!! 필드명 바꾸면 고칠게많을 것 같아서 언더바로 해결했습니다ㅎㅎ..
likeCommentDTO.content(), | ||
likeCommentDTO.postName(), | ||
likeCommentDTO.type(), | ||
likeCommentDTO.createdDate()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 creeatedDate 를 ~~분 전 ~~시간 전 이렇게 반환할 수 있도록 하는 클래스 만들어놨어요 다른 응답 DTO 참고해서 수정해주시면 될 거 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!
#️⃣연관된 이슈
📝작업 내용
💬리뷰 요구사항(선택)