Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 마이페이지 기능을 일부 구현한다 #25 #31

Merged
merged 17 commits into from
Jan 25, 2025

Conversation

chaen-ing
Copy link
Member

@chaen-ing chaen-ing commented Jan 23, 2025

#️⃣연관된 이슈

#25

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

스크린샷 2025-01-23 오후 8 19 55
  • 마이페이지 기능들 중 위의 기능들 완료하였습니다
스크린샷 2025-01-23 오후 8 19 38
  • 스크랩한 퀴즈 조회와 개념학습 조회를 위해 추가로 구현한 api입니다
  • 개별 저장 및 조회를 구현하였습니다

💬리뷰 요구사항(선택)

스크랩한 기사, 단어와 각각에 따른 조회 api도 추후 구현하겠습니다!

@chaen-ing chaen-ing added the ✨ Feat 새로운 기능 추가 label Jan 23, 2025
@chaen-ing chaen-ing added this to the #3 - 마이페이지 1/2 milestone Jan 23, 2025
@chaen-ing chaen-ing requested a review from chanmin-00 January 23, 2025 11:22
@chaen-ing chaen-ing self-assigned this Jan 23, 2025
@chaen-ing chaen-ing linked an issue Jan 23, 2025 that may be closed by this pull request
10 tasks
Copy link
Member

@chanmin-00 chanmin-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!! 양이 엄청 많은데 알아보기 쉽게 너무 잘 짜신거 같습니다

@@ -21,4 +21,11 @@ List<Quiz> findAllByLearningSetAndLevel(
@Param("learningSet") LearningSet learningSet, @Param("level") Level level);

List<Quiz> findAllByPurpose(Purpose purpose);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 querydsl로 작성하면 어떠세요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 좋습니다 수정할게요!

@Repository
public interface ConceptScrapRepository
extends JpaRepository<ConceptScrap, Long>, ConceptScrapRepositoryCustom {
Boolean existsByConcept_ConceptIdAndUserId(Long conceptId, Long userId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 혹시 _ 쓰신 이유 알수 있을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept클래스의 id가 conceptId로 되어있어서 existByConceptIdAndUserID 이거로는 조회가 안되더라구요!! 필드명 바꾸면 고칠게많을 것 같아서 언더바로 해결했습니다ㅎㅎ..

likeCommentDTO.content(),
likeCommentDTO.postName(),
likeCommentDTO.type(),
likeCommentDTO.createdDate());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 creeatedDate 를 ~~분 전 ~~시간 전 이렇게 반환할 수 있도록 하는 클래스 만들어놨어요 다른 응답 DTO 참고해서 수정해주시면 될 거 같아요

Copy link
Member

@chanmin-00 chanmin-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@chaen-ing chaen-ing merged commit d8a7bc2 into develop Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 마이페이지 기능을 구현한다
2 participants