-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : 마이페이지 기능을 위한 저장기능을 구현한다 #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드가 깔끔하니 좋네요 수고하셨습니다!
@PostMapping("/learning/quiz/{quizId}/scrap") | ||
public ResponseEntity<ApiResponse<?>> scrapQuiz( | ||
final @AuthenticationPrincipal CustomUserDetails currentUser, | ||
final @PathVariable("quizId") long conceptId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 변수명 수정 필요할거 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그러네요 수정하겠스빈다!!
@@ -83,17 +88,17 @@ public QuizResultDTO submitAnswer(final long userId, final long quizId, final in | |||
|
|||
QuizListDTO quizListDTO = | |||
quizRedisService.fetchFromRedis(userId, QUESTION_TYPE, QuizListDTO.class); | |||
|
|||
// 마이페이지의 저장한 퀴즈에서 다시풀기 진행 시 (퀴즈 진행 redis 데이터가 없을 경우) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이 부분은 생각 못했는데 추가해주셔서 감사합니다
.answer() | ||
.trim() | ||
.equals(quizDTO.choiceList().choices().get(answerIndex).content().trim()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메소드로 따로 뺀 부분 좋은거 같아요
#️⃣연관된 이슈
📝작업 내용
💬리뷰 요구사항(선택)