Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure logging #23

Closed
5 tasks
Tom-Willemsen opened this issue Aug 22, 2024 · 2 comments
Closed
5 tasks

Configure logging #23

Tom-Willemsen opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Aug 22, 2024

Read:

And then:

  • Configure python loggers for ibex_bluesky_core following best practices in the documents linked above
  • Add some initial debug logging in "obvious places" e.g. in DAE and blocks devices, ISIS-specific callbacks, describing what they're doing.

We need to do this so that we can get appropriate debugging information to support this system when it's in use on the instruments.

Acceptance criteria:

  • ibex_bluesky_core can use python's stdlib logging module to log stuff
  • The log messages from both bluesky itself and ibex_bluesky_core, at a suitable log level, end up in c:\instrument\var\logs\bluesky\
  • Ensure log file gets rotated every day so that log rotation scripts can move it
  • Documentation about how to increase the log level(s) if we need more information to diagnose a problem
  • Above location added to log rotation script
@Chsudeepta
Copy link
Contributor

The following PRs have been created:
Changes for logger: #40
Changes for log archiving script: https://github.com/ISISComputingGroup/EPICS/pull/371
Changes for system tests: ISISComputingGroup/system_tests#114

One caveat is that many system tests were failing, including the new ones added here. But these tests ran fine from in isolation (executed as unit tests).

@Chsudeepta Chsudeepta moved this from In Progress to Review in PI_2024_08 Oct 17, 2024
@jackbdoughty jackbdoughty added the under review Issue is under review label Oct 23, 2024
@ISISBuilder ISISBuilder removed review under review Issue is under review labels Oct 28, 2024
@jackbdoughty jackbdoughty closed this as completed by moving to Done in PI_2024_08 Oct 28, 2024
@Tom-Willemsen
Copy link
Contributor Author

Can we write a follow-up issue for the second acceptance criteria:

Add some initial debug logging in "obvious places" e.g. in DAE and blocks devices, ISIS-specific callbacks, describing what they're doing.

Since it doesn't seem to be in the PRs above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants