Ticket 23 configure bluesky logging #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2024 13:13
5 tasks
jackbdoughty
requested changes
Oct 24, 2024
test_bluesky.py
Outdated
| @@ -181,6 +187,45 @@ def _plan(): | |||
| # Assert we successfully set npoints periods | |||
| self.assertEqual(g.get_number_periods(), npoints) | |||
|
|
|||
| def test_GIVEN_logging_is_requested_THEN_the_log_folder_exists(): | |||
There was a problem hiding this comment.
Needs to be def test_GIVEN_logging_is_requested_THEN_the_log_file_exists(self): -> None. Same for lines 201 and 213
| this_function_name = sys._getframe().f_code.co_name | ||
| message = LOG_MESSAGE + this_function_name | ||
| logger.blueskylogger.info(message) | ||
| qualified_log_filename = os.path.join(log_path, LOG_FILE_NAME) |
There was a problem hiding this comment.
I think LOG_FILE_NAME needs defining similar to the other environment variables at the top of the file
There was a problem hiding this comment.
Added missed constant
|
@jackbdoughty , I have corrected the issues, including the ruff ones |
jackbdoughty
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Some system tests have been added for testing the bluesky logger
Ticket
Link to Ticket
Acceptance criteria
The system tests should run successfully as a complete set or when executed individually
System tests
Added tests to check the following:
Code Review
Final Steps