Skip to content

Commit

Permalink
[Update_XML][Fixed] Components excluded from the board reported anyways
Browse files Browse the repository at this point in the history
Closes #585
  • Loading branch information
set-soft committed Mar 4, 2024
1 parent ea51835 commit 2a0596e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Netlist generation problems with components on the PCB but not in schematic.
(#578)
- Filters: _none filter not always honored (i.e. exclude in BoM) (#580)
- PCB Parity: components excluded from the board reported anyways (#585)

## [1.6.4] - 2024-02-02
### Added
Expand Down
2 changes: 2 additions & 0 deletions kibot/pre_update_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ def check_components(self, comps, errors):
for p in set(pcb_props.keys()).difference(found_props):
errors.append('{} PCB property `{}` not in schematic'.format(ref, p))
for ref in set(comps.keys()).difference(found_comps):
if 'exclude_from_board' in comps[ref].props:
continue
errors.append('{} found in schematic, but not in PCB'.format(ref))
return excluded

Expand Down

0 comments on commit 2a0596e

Please sign in to comment.