Address DREF Imminent changes feedback #1799

frozenhelium · 2025-04-25T05:49:28Z

Summary

Update styling of Proposed Actions table
Add a confirmation while creating Operational Update from Imminent DREF application
Add a popup to show and force change type of DREF to Response for existing Imminent Ops. Update

Addresses

DREF Imminent returns! #1455 (comment)

changeset-bot · 2025-04-25T05:49:31Z

⚠️ No Changeset found

Latest commit: 42f3153

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

AdityaKhatri · 2025-04-28T10:51:22Z

app/src/views/AccountMyFormsDref/DrefTableActions/i18n.json

@@ -13,6 +13,8 @@
        "drefApprovalInProgressTitle": "Approval in progress...",
        "drefAccountCouldNotCreate": "Could not create new operational update",
        "drefAccountCouldNotCreateFinalReport": "Could not create final report",
-        "drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure, you want to Approve?"
+        "drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure, you want to Approve?",


Suggested change

"drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure, you want to Approve?",

"drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure you want to Approve?",

barshathakuri · 2025-04-28T11:11:00Z

@frozenhelium Handle for empty Proposed Actions:

barshathakuri · 2025-04-28T11:12:05Z

@frozenhelium The list of activities is displaying in a row.

barshathakuri · 2025-04-28T11:17:08Z

@frozenhelium I don't see this confirmation as well as popup Add a confirmation while creating Operational Update from Imminent DREF application.

barshathakuri · 2025-05-05T11:00:12Z

app/src/views/AccountMyFormsDref/DrefTableActions/index.tsx

+                    response?.type_of_dref === DREF_TYPE_IMMINENT
+                        // FIXME: add translations


Use translation.

barshathakuri · 2025-05-05T11:00:43Z

app/src/views/AccountMyFormsDref/DrefTableActions/index.tsx

-                    response?.type_of_dref_display === 'Imminent'
-                    // FIXME: can't compare imminent with Imminent Crisis directly
+                    response?.type_of_dref === DREF_TYPE_IMMINENT
+                        // FIXME: add translations


Use translation.

barshathakuri · 2025-05-05T11:02:33Z

app/src/views/DrefApplicationExport/index.tsx

+                                <img
+                                    className={styles.icon}
+                                    src={proposedAction.icon}
+                                    alt=""


Add alert text.

barshathakuri · 2025-05-05T11:03:22Z

app/src/views/DrefApplicationExport/index.tsx

+                                                {activity.activity}
+                                            </div>
+                                            {i === 0 && (
+                                                <div


Can we write index here instead of i?

frozenhelium force-pushed the fix/imminent-changes-feedback branch from 6b10772 to 793b5ab Compare April 25, 2025 05:51

frozenhelium temporarily deployed to test April 25, 2025 05:51 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 05:52 — with GitHub Actions Inactive

frozenhelium force-pushed the fix/imminent-changes-feedback branch from 793b5ab to a4029ca Compare April 25, 2025 06:04

frozenhelium temporarily deployed to test April 25, 2025 06:04 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 06:05 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 06:06 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 07:57 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 07:58 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 07:59 — with GitHub Actions Inactive

frozenhelium force-pushed the fix/imminent-changes-feedback branch from 7579b94 to 2aa0b76 Compare April 25, 2025 08:02

frozenhelium temporarily deployed to test April 25, 2025 08:02 — with GitHub Actions Inactive

frozenhelium requested a review from shreeyash07 April 25, 2025 08:03

frozenhelium temporarily deployed to test April 25, 2025 08:03 — with GitHub Actions Inactive

frozenhelium force-pushed the fix/imminent-changes-feedback branch from 2aa0b76 to 6dd41cb Compare April 25, 2025 11:52

frozenhelium temporarily deployed to test April 25, 2025 11:52 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test April 25, 2025 11:53 — with GitHub Actions Inactive

AdityaKhatri approved these changes Apr 28, 2025

View reviewed changes

AdityaKhatri requested a review from barshathakuri April 28, 2025 10:55

barshathakuri approved these changes Apr 28, 2025

View reviewed changes

frozenhelium temporarily deployed to test May 5, 2025 08:12 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test May 5, 2025 08:13 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test May 5, 2025 08:14 — with GitHub Actions Inactive

frozenhelium requested a review from barshathakuri May 5, 2025 08:15

frozenhelium requested a review from AdityaKhatri May 5, 2025 08:15

barshathakuri reviewed May 5, 2025

View reviewed changes

frozenhelium added 2 commits May 5, 2025 16:58

Update styling of proposed actions in export

2ebfeac

Add a confirmation popup before creating ops. update from imminent dref

42f3153

frozenhelium force-pushed the fix/imminent-changes-feedback branch from 04aa0c2 to 42f3153 Compare May 5, 2025 11:14

frozenhelium temporarily deployed to test May 5, 2025 11:14 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test May 5, 2025 11:15 — with GitHub Actions Inactive

barshathakuri merged commit 8a16367 into project/dref-imminent May 5, 2025
17 checks passed

barshathakuri deleted the fix/imminent-changes-feedback branch May 5, 2025 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address DREF Imminent changes feedback #1799

Address DREF Imminent changes feedback #1799

frozenhelium commented Apr 25, 2025 •

edited

Loading

changeset-bot bot commented Apr 25, 2025 •

edited

Loading

AdityaKhatri Apr 28, 2025

barshathakuri commented Apr 28, 2025 •

edited

Loading

barshathakuri commented Apr 28, 2025

barshathakuri commented Apr 28, 2025 •

edited

Loading

barshathakuri May 5, 2025

barshathakuri May 5, 2025

barshathakuri May 5, 2025

barshathakuri May 5, 2025

	"drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure, you want to Approve?",
	"drefAccountConfirmMessage": "You're about to Approve this DREF. Once approved, it can no longer be edited. Are you sure you want to Approve?",

		response?.type_of_dref === DREF_TYPE_IMMINENT
		// FIXME: add translations

Address DREF Imminent changes feedback #1799

Address DREF Imminent changes feedback #1799

Conversation

frozenhelium commented Apr 25, 2025 • edited Loading

Summary

Addresses

changeset-bot bot commented Apr 25, 2025 • edited Loading

⚠️ No Changeset found

AdityaKhatri Apr 28, 2025

Choose a reason for hiding this comment

barshathakuri commented Apr 28, 2025 • edited Loading

barshathakuri commented Apr 28, 2025

barshathakuri commented Apr 28, 2025 • edited Loading

barshathakuri May 5, 2025

Choose a reason for hiding this comment

barshathakuri May 5, 2025

Choose a reason for hiding this comment

barshathakuri May 5, 2025

Choose a reason for hiding this comment

barshathakuri May 5, 2025

Choose a reason for hiding this comment

frozenhelium commented Apr 25, 2025 •

edited

Loading

changeset-bot bot commented Apr 25, 2025 •

edited

Loading

barshathakuri commented Apr 28, 2025 •

edited

Loading

barshathakuri commented Apr 28, 2025 •

edited

Loading