Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proposed Action for Dref Application Form #1632

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

shreeyash07
Copy link
Collaborator

Summary

This PR adds proposed action form in Dref Application form when Dref type is Imminent.

Addresses

Depends On

Changes

  • New Input component for Proposed Action
  • Custom form Array for Proposed Action

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: ff3785e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 changed the base branch from develop to project/dref-imminent-returns January 23, 2025 08:59
app/src/views/DrefApplicationForm/common.tsx Outdated Show resolved Hide resolved
keySelector: (n) => n.client_id,
member: () => ({
fields: (): ProposedActionsFields => ({
client_id: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be required as per my knowledge. Can you confirm @samshara @tnagorra @frozenhelium ?

app/src/views/DrefApplicationForm/Operation/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@AdityaKhatri AdityaKhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreeyash07 to create an issue for this to discuss further.

@samshara samshara merged commit 7dd8233 into project/dref-imminent-returns Jan 24, 2025
10 of 11 checks passed
@samshara samshara deleted the feature/proposed-actions branch January 24, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants