Add fdrs fetched date #2119
Merged
Add fdrs fetched date #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
thenav56
requested changes
Apr 26, 2024
Comment on lines
+538
to
+542
| fdrs_data_fetched_year = models.CharField( | ||
| verbose_name=_('FDRS Data Fetched Year'), | ||
| null=True, blank=True, | ||
| max_length=50 | ||
| ) |
There was a problem hiding this comment.
Any reason why we are storing year in string?
There was a problem hiding this comment.
We get year as string from data source and populating that here.
Comment on lines
124
to
125
| get_max_year = lambda data: max(int(item['year']) for item in fdrs_data.values()) | ||
| fdrs_data_fetched_year = get_max_year(fdrs_data) |
There was a problem hiding this comment.
Any reason why we need lambda here instead of simple statement?
There was a problem hiding this comment.
Replaced with normal statement
k9845
force-pushed
the
feature/fdrs_fetched_date
branch
from
a732ae2 to
6da10f7
Compare
samshara
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
fdrs_data_fetched_yearNOTE: Please run the following command on staging server
docker-compose exec serve bash ./manage.py ingest_databankChecklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.