Feature/check svg file type #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabozoltan69
force-pushed
the
feature/check-svg-file-type
branch
5 times, most recently
from
9c2496b to
8e65199
Compare
thenav56
requested changes
Mar 26, 2024
There was a problem hiding this comment.
@szabozoltan69 Look good.
I noticed the validation using file_field in validated_data. It is much easier to have a function validate_<file_field> instead, as it will handles both create and update, and we don't have to check if the field is provided by the client for different API methods.
szabozoltan69
force-pushed
the
feature/check-svg-file-type
branch
from
8e65199 to
b445069
Compare
|
@thenav56 I implemented the suggested changes. Really nicer this way! :-) |
|
(Also tested it locally.) |
thenav56
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating file uploads.
Also fixes #2077 (which issue was a blocker of proper testing).