-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Resource Controller): Remove aliases and bindings #369
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Hi @apoorva9s14 , it looks like your PR build failed because the resource-controller's examples still have references to things that were apparently removed. In your sandbox, you can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix the linter errors in the resource-controller examples.
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR summary
Remove SDK references for CF aliases and bindings
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
The current behaviour has SDK references for CF aliases and bindings, new behaviour has the references for CF aliases and bindings are removed
Does this PR introduce a breaking change?
If any users are using references for aliases and bindings SDK, then the users should be aware that aliases and bindings are no longer supported in RC
Other information
https://cloud.ibm.com/apidocs/resource-controller/resource-controller The APIDocs are updated to remove references for CF aliases and bindings