Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Resource Controller): Remove aliases and bindings #369

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

apoorva9s14
Copy link
Contributor

@apoorva9s14 apoorva9s14 commented Jan 16, 2025

PR summary

Remove SDK references for CF aliases and bindings

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • [ ✓] The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • [✓ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

The current behaviour has SDK references for CF aliases and bindings, new behaviour has the references for CF aliases and bindings are removed

Does this PR introduce a breaking change?

  • [✓ ] Yes
  • No
    If any users are using references for aliases and bindings SDK, then the users should be aware that aliases and bindings are no longer supported in RC

Other information

https://cloud.ibm.com/apidocs/resource-controller/resource-controller The APIDocs are updated to remove references for CF aliases and bindings

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
@apoorva9s14 apoorva9s14 changed the title Remove aliases and bindings fix(Resource Controller) -Remove aliases and bindings Jan 16, 2025
@apoorva9s14 apoorva9s14 changed the title fix(Resource Controller) -Remove aliases and bindings fix(Resource Controller): Remove aliases and bindings Jan 16, 2025
@padamstx padamstx self-assigned this Jan 21, 2025
@padamstx
Copy link
Member

Hi @apoorva9s14 , it looks like your PR build failed because the resource-controller's examples still have references to things that were apparently removed. In your sandbox, you can run make all and it will run all the project's unit tests, plus run the linter on all unit/integration test and the examples code.

@padamstx padamstx self-requested a review January 21, 2025 19:30
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the linter errors in the resource-controller examples.

Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
@apoorva9s14 apoorva9s14 requested a review from padamstx January 24, 2025 15:10
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants