second part of supporting istio egress gateways #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pairs (key, value) to allow missing pods having the same label key but different label values. Bug fix in IngressNetworkLayer._allowed_xgress_conns_optimized: all_allowed_conns should always include allowed_conns. Signed-off-by: Tanya <tatyana@il.ibm.com>
Bug fix: considering DNS entries when computing allowed connections in the Ingress layer. Removing duplicates from the list of missing livesim resources. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…on of istio-egressgateway resource to livesim, and changing the namespace of istio-ingressgateway to istio-system. Signed-off-by: Tanya <tatyana@il.ibm.com>
…ding policy rules. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…ned with livesim, until #610 is implemented). Extending IngressPolicy to both directions (ingress/egress) Splitting livesim ingress/egress gateway resources to separated files. Signed-off-by: Tanya <tatyana@il.ibm.com>
…ned with livesim, until #610 is implemented). Extending IngressPolicy to both directions (ingress/egress) Splitting livesim ingress/egress gateway resources to separated files. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…according to the change in livesim implementation of these gateways. Temporarily commenting out other expected results, until ingress/egress gateway implementation is completes. Signed-off-by: Tanya <tatyana@il.ibm.com>
…according to the change in livesim implementation of these gateways. Signed-off-by: Tanya <tatyana@il.ibm.com>
…for-istio-egress-gateway-part2
adisos
changed the base branch from
master
to
566-support-for-istio-egress-gateway
adisos
reviewed
Oct 15, 2023
adisos
reviewed
Oct 15, 2023
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
566-support-for-istio-egress-gateway Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Updated istio-ingress-test and its expected results. Signed-off-by: Tanya <tatyana@il.ibm.com>
Renamed Ingress policy kind and Ingress layer name to IngressEgressGateway policy type and layer name. Renamed IngressNetworkLayer to GatewayLayer. Changed creation of deny policy - a single deny policy with one rule. Handling denied connections in GatewayLayer; using captured_cond_func (to avoid denied connections affect captured). Signed-off-by: Tanya <tatyana@il.ibm.com>
Fixing lint errors. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
tanyaveksler
changed the base branch from
566-support-for-istio-egress-gateway
to
master
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…eway-part2' into 566-support-for-istio-egress-gateway-part2
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Adding empty gateway policy in case no policies were generated, in order to keep findings. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
reviewed
Dec 26, 2023
Comment on lines
98
to
100
| self.vs_parser.warning(f"Ignoring partially defined egress flow: mesh-to-egress-gateway part of the flow " | ||
| f"is {part1_status}, while egress-gateway-to-external-service part of the flow " | ||
| f"is {part2_status}") |
There was a problem hiding this comment.
rephrase the warning, add details on the VS ignored
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
reviewed
Dec 26, 2023
| - name: istio-egress | ||
| resourceList: | ||
| - ./resources | ||
| expectedWarnings: 3 |
There was a problem hiding this comment.
for this test I can see two related warnings:
Warning: Ignoring partially specified connections through egress gateway: mesh-to-egress-gateway connections are missing, while egress-gateway-to-external-service connections are specified in virtual service default/httpbin, route number 1, gateway istio-system/my-gateway.
Warning: no valid VirtualServices found. Ignoring istio ingress/egress gateway traffic
Can we avoid the second warning here?
Also, in cases the second warning is relevant, can it specify ingress or egress only?
There was a problem hiding this comment.
Avoided printing the second warning in the above case.
Removed 'ingress/egress' from the second warning, apparently for invalid/partially defined virtual services / gateways we cannot always detect whether it is an ingress or egress flow.
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #637