feat: update vmware service #5926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Jan 23, 2025
ibm/conns/config.go
Outdated
| vmwareURL := ContructEndpoint(fmt.Sprintf("api.%s.vmware", c.Region), cloudEndpoint+"/v1") | ||
| vmwareClientOptions := &vmwarev1.VmwareV1Options{ | ||
| Authenticator: authenticator, | ||
| URL: EnvFallBack([]string{"VMWARE_URL"}, vmwareURL), |
There was a problem hiding this comment.
Append IBMCLOUD to VMWARE_URL to keep inline with all other services
| @@ -157,6 +161,18 @@ func ResourceIbmVmaasVdc() *schema.Resource { | |||
| Description: "The public IP addresses assigned to the edge.", | |||
| Elem: &schema.Schema{Type: schema.TypeString}, | |||
| }, | |||
| "private_ips": &schema.Schema{ | |||
There was a problem hiding this comment.
The top attribute "edges" is computed the inner attributes can't be optioanl
There was a problem hiding this comment.
Same comment holds for all below changes
| @@ -3,7 +3,7 @@ layout: "ibm" | |||
| page_title: "IBM : ibm_vmaas_vdc" | |||
| description: |- | |||
| Get information about vmaas_vdc | |||
| subcategory: "VMware as a Service API" | |||
| subcategory: "VMware Cloud Foundation as a Service API" | |||
There was a problem hiding this comment.
do we need this big name for subcategory?
This subcategory is for docs in registy
There was a problem hiding this comment.
I'll shorten it to VCF as a Service API
hkantare
reviewed
Jan 24, 2025
| @@ -3,7 +3,7 @@ layout: "ibm" | |||
| page_title: "IBM : ibm_vmaas_vdc" | |||
| description: |- | |||
| Get information about vmaas_vdc | |||
| subcategory: "VMware as a Service API" | |||
| subcategory: "VCF as a Service API" | |||
There was a problem hiding this comment.
why are we renaming from VMware to VCF.
We should rename in subcategory.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Output from acceptance testing: