-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
bornagain 22.0 (new formula) #218251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bornagain 22.0 (new formula) #218251
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put some comments on the install block, but this is way too much custom logic to be maintainable. Please check other formula to see how formulae usually install python wheels.
Please, do not use I'd recommend to read docs about |
BornAgain is an open-source research software to simulate and fit neutron and x-ray reflectometry and grazing-incidence small-angle scattering. BornAgain has a GUI which can interoperate with a Python interpreter. It can be also used as a Python package. homepage: <https://bornagainproject.org> source: <https://jugit.fz-juelich.de/mlz/bornagain.git>
50c1569
to
5234723
Compare
Revision 3: * Removed architecture requirement. * Extracted shim-producing part of the code as an extra function.
* Removed unnecessary comments. * Simplified the CMake commands. * Removed `Etc.nprocessors` usage.
Added a numerical test for the libraries.
Added a numerical test; see revision d0c9522. |
Add explicit CMake paths for libheinz and libformfactor.
This still needs a lot of work. Given that it's also not very notable software, I'm not inclined to accept this. Please consider hosting this in your own Homebrew tap instead. |
A Homebrew formula is added to build the BornAgain GUI and its related Python wheel.
BornAgain is an open-source research software to simulate and fit neutron and x-ray reflectometry and grazing-incidence small-angle scattering. BornAgain has a GUI which can interoperate with a Python interpreter. It can be also used as a Python package.
homepage: https://bornagainproject.org
source: https://jugit.fz-juelich.de/mlz/bornagain.git
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?BornAgain v22.0 needs, in particular,
libheinz
v2.0.1 andlibformfactor
v0.3.2 (latest versions of the respective libraries).However, I could not update these libraries via
brew bump-formula-pr
as they are apparently automatically updated.For instance, with
brew bump-formula-pr libformfactor
I get the following error message:With
brew audit --new bornagain
, I get the following errors which I cannot resolve:Reason:
* BornAgain is compatible with Python 3.x with x >= 10 (not just 3.13).
* BornAgain requires Qt6.
* The build log should be included in the distribution and is needed for bug reports.
* BornAgain needs its own Python virtual environment, hence the extra binaries.
* Currently BornAgain libraries do not have a version number. This cannot be changed at the moment.