[WIP] Beam read_from_file also reads spin #1172
Open
+88
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
changed the title
MaxThevenet
changed the title
Co-authored-by: Alexander Sinn <64009254+AlexanderSinn@users.noreply.github.com>
AlexanderSinn
approved these changes
Oct 14, 2024
|
Thanks for the review, some tests are on the way, I'll merge once we have confirmation that it works as expected. |
MaxThevenet
changed the title
Co-authored-by: Alexander Sinn <64009254+AlexanderSinn@users.noreply.github.com>
|
Restart test |
|
Looks great! was this on GPU? If not, do you know why there is a tiny difference, don't we expect them to be equal to machine precision? |
|
Unfortunately, there are tiny differences even on CPU. I added some oscillations in x to the witness so the spin has a signal. Without that, the spin is very constant, and both cases are within 1e-6, but with the autoscale plot the restart looks different. One possible reason for this could be that the momentum is multiplied with the speed of light and its inverse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @pots007, when reading a beam from file the spin data is currently ignored. This PR proposes to fix this. The behavior is determined by the user: if
do_spin_trackingis specified, the corresponding runtime components are allocated and read from file. Otherwise, they are neither allocated nor read.