Optimising for availability queries #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/hutch_bunny/core/query_solvers.py
Previously it first seeded the dataframe from the first in the list, then interated through the rest of the list. All but the operator and the label was the same, therefore now account for when its the first iteration of the loop, and it switches the label to use on the dataframe. For the statement building to switch between equals and not equals a new function created.
AndyRae
reviewed
Jan 23, 2025
…n and not generally
# Conflicts: # src/hutch_bunny/core/query_solvers.py
…_optimise # Conflicts: # src/hutch_bunny/core/query_solvers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
♻️ Refactor - reducing repetition of similar code so that the queries are easier to maintain and adjust over time.
Description
Removed repetition that was created to initiate the first data frame and then the subsequent merges.
Related Issues or other material
Related Issue Refactor query solvers #47
I've completed all actions and tasks detailed in the PR Template