Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow #48

Open
jochemvogel opened this issue Aug 27, 2022 · 0 comments
Open

Update workflow #48

jochemvogel opened this issue Aug 27, 2022 · 0 comments
Labels
on-hold workflow Github Action related tasks

Comments

@jochemvogel
Copy link
Member

jochemvogel commented Aug 27, 2022

In the workflows (Github Actions) we use environment variables/secrets. Those are not accessible in forked repos. So when people try to make a change, the CI will fail, because they don't have access to the secrets.

Update pull_request to pull_request_target will probably do the trick. This isn't a very safe way according this article, but for this repo that's not a big deal.

Github fixed it tho, but (logically) only for private repos.

Only necessary for the Development CI, that's the only one that's triggered when a fork is being merged.

https://github.com/jochemvogel/ictmethods.nl/pull/47

Sources:

jochemvogel added a commit that referenced this issue Aug 27, 2022
@jochemvogel jochemvogel added the workflow Github Action related tasks label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold workflow Github Action related tasks
Projects
None yet
Development

No branches or pull requests

1 participant