Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update About page since Dark mode is released #47

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Update About page since Dark mode is released #47

merged 1 commit into from
Aug 27, 2022

Conversation

Lucky-Loek
Copy link
Contributor

Description

This awesome app already includes Dark mode, so let's show off on the About page!

Let me know if I still need to build the thing, or that it's okay to just leave it at this.

Type of change

Please select the option that is relevant

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • All the required documentation is added.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

Additional information

None

@jochemvogel
Copy link
Member

jochemvogel commented Aug 25, 2022

Thanks! CI is failing, because somehow it can't find the env variable (which is a just the (public) API URL). Already added it to the workflow and the repository secrets, so that doesn't make sense. Will have a look at it later.

@jochemvogel
Copy link
Member

jochemvogel commented Aug 27, 2022

A little bit more complicate than I thought (https://github.com/jochemvogel/ictmethods.nl/issues/48). Gonna try a few things and otherwise hard code the API URL in the workflow, but there has to be a way of fixing this ⏳

This change wouldn't affect anything, so I'm just gonna merge this one. Thanks again!

@jochemvogel jochemvogel mentioned this pull request Aug 27, 2022
@jochemvogel jochemvogel merged commit f7e07ac into HBO-i:development Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants