Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EphemeralWriteOnly: add rsaEncryptionKeyWo+rawKeyWo in compute_disk / region_compute_disk #12783

Open
wants to merge 24 commits into
base: FEATURE-BRANCH-ephemeral-write-only
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jan 16, 2025

Put a description of what this PR is for here, along with any references to issues that this resolves or contributes to.
For example: Fixes https://github.com/hashicorp/terraform-provider-google/issues/ISSUE_ID
-->

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `raw_key_wo`, `rsa_encrypted_key` and `new_keys_wo` fields in `resource_google_compute_disk` resource
compute: added `raw_key_wo` and `new_keys_wo` fields in `resource_google_region_compute_disk` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to build branch auto-pr-12783-old

google-beta provider:

  • Failed to build branch auto-pr-12783-old

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 2 files changed, 45 insertions(+), 35 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau force-pushed the compute_disk_writeonly branch from a132f08 to 81c6180 Compare January 17, 2025 01:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 43 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 2 files changed, 43 insertions(+), 35 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau force-pushed the compute_disk_writeonly branch from 81c6180 to 2233c5a Compare February 5, 2025 01:37
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 65 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 2 files changed, 65 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (163 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  disk_encryption_key {
    raw_key_wo           = # value needed
    rsa_encrypted_key_wo = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1073
Passed tests: 972
Skipped tests: 73
Affected tests: 28

Click here to see the affected service packages
  • compute

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyAssociation_basic
  • TestAccComputeFirewallPolicyRule_basic
  • TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample
  • TestAccComputeFirewallPolicyRule_multipleRules
  • TestAccComputeFirewallPolicyRule_securityProfileGroup_update
  • TestAccComputeFirewallPolicyRule_update
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicy_update
  • TestAccComputeInstance_bootAndAttachedDisk_interface
  • TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
  • TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
  • TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample
  • TestAccComputeInterconnect_computeInterconnectMacsecTest
  • TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeNetwork_default_bgp_always_compare_med
  • TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
  • TestAccDataSourceComputeInstanceGuestAttributes_basic
  • TestAccDataSourceComputeInstance_networkAttachmentUsageExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]
TestAccComputeFirewallPolicyRule_basic [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update [Debug log]
TestAccComputeFirewallPolicyRule_update [Debug log]
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeFirewallPolicy_update [Debug log]
TestAccComputeInstance_bootAndAttachedDisk_interface [Debug log]
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Debug log]
TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetwork_default_bgp_always_compare_med [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway [Debug log]
TestAccDataSourceComputeInstanceGuestAttributes_basic [Debug log]
TestAccDataSourceComputeInstance_networkAttachmentUsageExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 205 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 2 files changed, 217 insertions(+), 56 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (163 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    raw_key_wo           = # value needed
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1073
Passed tests: 992
Skipped tests: 73
Affected tests: 8

Click here to see the affected service packages
  • compute

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_accessModeSpecified
  • TestAccComputeDisk_attributionLabelOnCreation
  • TestAccComputeDisk_featuresUpdated
  • TestAccComputeDisk_pdHyperDiskProvisionedIopsLifeCycle
  • TestAccComputeDisk_pdHyperDiskProvisionedThroughputLifeCycle
  • TestAccComputeDisk_update
  • TestAccComputeInterconnect_computeInterconnectMacsecTest
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectMacsecTest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeDisk_accessModeSpecified [Error message] [Debug log]
TestAccComputeDisk_attributionLabelOnCreation [Error message] [Debug log]
TestAccComputeDisk_featuresUpdated [Error message] [Debug log]
TestAccComputeDisk_pdHyperDiskProvisionedIopsLifeCycle [Error message] [Debug log]
TestAccComputeDisk_pdHyperDiskProvisionedThroughputLifeCycle [Error message] [Debug log]
TestAccComputeDisk_update [Error message] [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau force-pushed the compute_disk_writeonly branch from fb2a366 to 0754908 Compare February 14, 2025 00:14
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 379 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 391 insertions(+), 56 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 46 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (166 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    raw_key_wo           = # value needed
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 4
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 377 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 389 insertions(+), 56 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (166 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    raw_key_wo           = # value needed
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 4
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 377 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 389 insertions(+), 56 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (166 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    raw_key_wo           = # value needed
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 4
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau
Copy link
Collaborator Author

BBBmau commented Feb 14, 2025

added #12789 due to files being shared across both resources.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 639 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 8 files changed, 651 insertions(+), 74 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 33 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (169 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 639 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 8 files changed, 651 insertions(+), 74 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 33 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (169 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 639 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 8 files changed, 651 insertions(+), 74 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 33 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (169 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    rsa_encrypted_key_wo = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 194
Passed tests: 132
Skipped tests: 59
Affected tests: 3

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated [Error message] [Debug log]
TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample [Error message] [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 368
Passed tests: 296
Skipped tests: 59
Affected tests: 13

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_accessModeSpecified
  • TestAccComputeDisk_attributionLabelOnCreation
  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
  • TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccComputeRouterInterface_withTunnel
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_Ipv6Basic
  • TestAccComputeRouterPeer_addImportAndExportPolicy
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 279
Passed tests: 214
Skipped tests: 60
Affected tests: 5

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
  • TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeRouterInterface_withTunnel

Get to know how VCR tests work

@BBBmau BBBmau force-pushed the compute_disk_writeonly branch from d6625ab to 8af16a7 Compare February 19, 2025 03:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 717 insertions(+), 81 deletions(-))
google-beta provider: Diff ( 10 files changed, 729 insertions(+), 84 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 66 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (180 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    rsa_encrypted_key_wo         = # value needed
    rsa_encrypted_key_wo_version = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 503
Passed tests: 421
Skipped tests: 63
Affected tests: 19

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_update_wo

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstance_bootAndAttachedDisk_interface
  • TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
  • TestAccComputeNetwork_default_bgp_always_compare_med
  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
  • TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey
  • TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeRouterInterface_withTunnel
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_addImportAndExportPolicy
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
  • TestAccComputeVpnTunnel_router

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_bootAndAttachedDisk_interface [Debug log]
TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample [Debug log]
TestAccComputeNetwork_default_bgp_always_compare_med [Debug log]
TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway [Debug log]
TestAccComputeVpnTunnel_router [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated [Error message] [Debug log]
TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau requested review from jrhouston and removed request for trodge February 19, 2025 04:31
@BBBmau
Copy link
Collaborator Author

BBBmau commented Feb 19, 2025

🟢 Tests passed during RECORDING mode: TestAccComputeInstance_bootAndAttachedDisk_interface [Debug log] TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Debug log] TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log] TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample [Debug log] TestAccComputeNetwork_default_bgp_always_compare_med [Debug log] TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey [Debug log] TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Debug log] TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Debug log] TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample [Debug log] TestAccComputeRouterInterface_withTunnel [Debug log] TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log] TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log] TestAccComputeRouterPeer_UpdateIpv6Address [Debug log] TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log] TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway [Debug log] TestAccComputeVpnTunnel_router [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated [Error message] [Debug log] TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

The write-only tests fail due to the use of 1.10. You can view the tests passing on the following TeamCity build: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_EPHEMERALWRITEONLYGA__MM_GOOGLE_PACKAGE_COMPUTE?branch=refs%2Fheads%2Fauto-pr-12783&buildTypeTab=overview

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 726 insertions(+), 81 deletions(-))
google-beta provider: Diff ( 10 files changed, 738 insertions(+), 84 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 66 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_disk (180 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_disk" "primary" {
  description = # value needed
  disk_encryption_key {
    rsa_encrypted_key_wo         = # value needed
    rsa_encrypted_key_wo_version = # value needed
  }
  interface = # value needed
  source_image_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
  source_snapshot_encryption_key {
    kms_key_self_link       = # value needed
    kms_key_service_account = # value needed
    raw_key                 = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 509
Passed tests: 428
Skipped tests: 63
Affected tests: 18

Click here to see the affected service packages
  • compute

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_accessModeSpecified
  • TestAccComputeDisk_attributionLabelOnCreation
  • TestAccComputeDisk_diskBasicWoExample
  • TestAccComputeDisk_featuresUpdated
  • TestAccComputeDisk_pdHyperDiskProvisionedIopsLifeCycle
  • TestAccComputeDisk_pdHyperDiskProvisionedThroughputLifeCycle
  • TestAccComputeDisk_update
  • TestAccComputeDisk_update_wo
  • TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
  • TestAccComputeInterconnect_computeInterconnectMacsecTest
  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_Ipv6Basic
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_basic
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeDisk_accessModeSpecified [Error message] [Debug log]
TestAccComputeDisk_attributionLabelOnCreation [Error message] [Debug log]
TestAccComputeDisk_diskBasicWoExample [Error message] [Debug log]
TestAccComputeDisk_featuresUpdated [Error message] [Debug log]
TestAccComputeDisk_pdHyperDiskProvisionedIopsLifeCycle [Error message] [Debug log]
TestAccComputeDisk_pdHyperDiskProvisionedThroughputLifeCycle [Error message] [Debug log]
TestAccComputeDisk_update [Error message] [Debug log]
TestAccComputeDisk_update_wo [Error message] [Debug log]
TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated [Error message] [Debug log]
TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants