(wip) gonfidel/implement-weighted-queues #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonfidel
changed the title
Gonfidel
commented
Feb 15, 2025
| @@ -71,7 +71,7 @@ func GetResourceGraphDefinitionInstanceGVK(group, apiVersion, kind string) schem | |||
| func GetResourceGraphDefinitionInstanceGVR(group, apiVersion, kind string) schema.GroupVersionResource { | |||
| pluralKind := flect.Pluralize(strings.ToLower(kind)) | |||
| return schema.GroupVersionResource{ | |||
| Group: fmt.Sprintf("%s.%s", pluralKind, group), | |||
| Group: group, | |||
There was a problem hiding this comment.
This is also remediated in kro-run#305 and is related to a bug that causes queues and informers to fail cleanup
Gonfidel
commented
Feb 15, 2025
| weight: weight, | ||
| queue: workqueue.NewNamedRateLimitingQueue( | ||
| workqueue.NewTypedMaxOfRateLimiter( | ||
| workqueue.NewTypedItemExponentialFailureRateLimiter[any](200*time.Millisecond, 1000*time.Second), |
There was a problem hiding this comment.
Old rate limiter types were failing linting due to deprecation warnings. New rate limiters support types. I believe any IS what we want here but feel free to correct me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue kro-run#198