-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XR_FB_face_tracking support #84
Conversation
Wow, this looks so cool! I'll review in depth when I have a chance :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this with the Quest Pro and it worked great! (Except the face model in the demo is a little creepy :-)) Skimming the code, it looks good to me as well
@Malcolmnixon Just to confirm, this only works on the Quest Pro, right? |
In my testing, it only works on the Quest Pro. I also tried on the Quest 3, but it does nothing there - it doesn't even show the permission overlay about face tracking |
I believe only the Quest Pro has the face-tracking cameras necessary to do this. |
@Malcolmnixon We should consider updating the implementation to use XR_FB_face_tracking2 instead. |
That will need us to update openxr to 1.0.34 first. I'll get a separate PR ready for that. |
This pull request adds support for the XR_FB_face_tracking extension to the Meta vendor plugin. Users can:
OpenXRFbFaceTrackingExtensionWrapper
singletonis_enabled()
methodget_weights()
method (indexed via enums)get_confidences()
method (indexed via enums)It includes a face model from https://booth.pm/en/items/5420804 which contains almost all the blend-shapes necessary to test the face-tracking feature; although the files are quite large for this.
OpenXR.Face.Tracking.mp4