-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option in metastore settings to stop forcing redirect #4381
Conversation
Need to add a test for this, moving back to draft. |
a649698
to
b3ff583
Compare
Updated the form structure to satisfy codeclimate now and in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @zedmonds96 - see one request about the test approach and another about form text
modules/metastore/modules/metastore_admin/tests/src/Functional/RedirectToDatasetsTest.php
Outdated
Show resolved
Hide resolved
35ac301
to
8b4b821
Compare
Fixes #4326
Describe your changes
Added a configuration option in metastore settings. If checked, the user will be redirected to the datasets view when creating/editing a dataset. If unchecked, the user will remain on the node page for the dataset instead of the redirect.
redirect_to_dataset
tometastore.settings.yml
.redirect_to_dataset
tometastore.schema.yml
.redirect_to_datasets
checkbox to the metastore settings form inDkanDataSettingsForm.php
metastore_admin_form_submit()
inmetastore_admin.module
to get the checkbox value on submission to determine redirect behavior.metastore_update_8010()
tometastore.install
to set the default value of the config.RedirectToDatasetsTest.php
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation