Add Readme section for 3rd party software #658
Conversation
PR Summary
|
There was a problem hiding this comment.
Do we need to add the following?
- Google Maps: Used to render maps - only when Google Maps is selected as your mapping platform.
- Open Street Map: Used to render maps - only when Open Street Map is selected as your mapping platform.
@stephenerdelyi I was going to add OSM as part of our OSM feature. I'm not sure if we need to add google maps since we are just iframing their map. What do you think @mauteri ? Also, does anyone know why the a php unit test would be failing on a simple readme change? |
@jmarx the logs know the answer, "they" said:
Should probably work on the next run. |
|
@mauteri Are we good to merge this? Or should we add the map items? |
|
I added all the changes also to #653 . |
|
|
||
| - [Moment.js](https://momentjs.com/): Used for date and time manipulation. | ||
| - [Moment-Timezone](https://momentjs.com/timezone/): Adds timezone support to Moment.js. | ||
| - [Playwright](https://playwright.dev/): Enables browser automation for testing and interaction. |
There was a problem hiding this comment.
Not needed here as it is not packaged with the plugin
|
|
||
| This plugin leverages the following third-party libraries for various functionalities: | ||
|
|
||
| - [Moment.js](https://momentjs.com/): Used for date and time manipulation. |
There was a problem hiding this comment.
Not needed as it's a WordPress external dependency.
|
Closing this PR as this should be done in @carstingaxion's PR at this point. |
Description of the Change
Add a section in the readme dedicated to giving credit to third party software integrations.
Closes #610
Can be added to @carstingaxion #653
I also created a pr off of @carstingaxion 's branch:
#657 (closed for now
Credits
Props @carstingaxion , @mauteri