Literate Cryptol specifications #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Thanks, @carrala! This is a nice improvement. I haven't read everything line by line (mainly because most of the text is taken directly from upstream specifications), but I did take a closer look at the Salsa20 implementation, which is the one that I'm most familiar with.
RyanGlScott
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Thanks, @carrala! This looks good on my end. Can you resolve the merge conflicts as well?
carrala
force-pushed
the
literate-specs
branch
from
7603f8f to
b9c51f3
Compare
|
@RyanGlScott All merge conflicts have been resolved! |
RyanGlScott
approved these changes
Jan 8, 2024
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces some Cryptol implementations of algorithms with literate Cryptol versions which include the text from the original specifications as well as any tests that were defined for the algorithms.
Updated algorithms include:
All tests for the new implementations pass locally.