Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.0 (Sprint 50) #2100

Merged
merged 85 commits into from
Feb 6, 2025
Merged

Release v0.10.0 (Sprint 50) #2100

merged 85 commits into from
Feb 6, 2025

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Feb 6, 2025

PR Summary

Related Github Issue

Application Improvements

Nested criteria not open as expected #2086
Clicking Back buttons on Firefox browser after entering required fields on ‘death of a loved one’ add an extra route with # on ‘about-the-deceased’ route #2058
child criteria is required cause error #2089

Custom Module Improvements

Remove boolean type of criteria #2080
Life event form criteria error message not showing in JSON data #2088
PHPStan error fixing #2039

a11y Improvements

Skip to main is breaking on tab enter #2065
Announce Web Page Title Changes to Screen Reader Users #1904

design Improvements

Color Updates from USA.gov AUDIT #2073

Detailed Testing steps

Application Improvements

Nested criteria not open as expected, under Date field types #2086

  • under date criteria on /disability, create a child criteria with the child dependency value of >=18years
  • navigate to first step
  • confirm child fieldsets are not visible
  • input date: >=18years
  • confirm child fieldsets are visible
  • adjust date: <18years
  • confirm child fieldsets are not visible
  • ensure you can complete form
  • ensure you can validate error alerts
  • ensure expected criteria still validates criteria correctly

expected:

Screen.Recording.2025-01-27.at.5.48.53.PM.mov

Clicking Back buttons on Firefox browser after entering required fields on ‘death of a loved one’ add an extra route with # on ‘about-the-deceased’ route #2058

  • Open the application in the Firefox browser.
  • Navigate to the ‘Death of a Loved One’ workflow.
  • Fill in all required fields and navigate to results page.
  • Click the browser’s Back button to return to navigate fully back to the Intro component while making note of the URL changes
  • expect Clicking the Back button should navigate back to the ‘about-the-deceased’ route without appending an extra # to the URL.

child criteria is required cause error #2089

Detailed Testing steps

  • under date criteria on /disability, create a child criteria with the child dependency value of >=18years
  • set criteria to required
  • navigate to first step
  • CLICK next
  • ensure error alert only shows visible required fields
  • input date <18years
  • resolve all other required fields
  • CLICK next
  • ensure step 2 renders
  • CLICK back
  • update date value to >=18years
  • ensure child criteria displays
  • CLICK next
  • ensure child criteria error is in alert
  • resolve error
  • CLICK next
  • ensure step 2 renders
  • CLICK back
  • input date <18years
  • ensure child criteria is not displayed
  • input date >=18years
  • ensure child criteria values are cleared

expected:

Screen.Recording.2025-01-29.at.8.46.51.AM.mov

Custom Module Improvements

Remove boolean type of criteria #2080

  • Pull changes locally
  • Make local development site up at http://localhost
  • Navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicate date of birth" edit page
  • Verify no Boolean in the list of Type field

Life event form criteria error message not showing in JSON data #2088

  • Pull changes locally
  • Make local development site up at http://localhost
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: disability" edit page
  • Go to criteria "Applicant date of birth"
  • Input "ERROR MESSAGE for applicant date of birth" in Error Message field
  • Save as published
  • Navigate to benefit-finder/disability
  • Click Next to "About the applicant" page
  • Click Next
  • Verify the error message having the value in Error Message field

PHPStan error fixing #2039

  • Navigate to node/add/bears_agency to create an agency
  • Language: English
  • Title: agency 1
  • Summary: agency 1 summary
  • Lede: agency 1 lede
  • Save as Published
  • Verify Generating both draft and published JSON data files
  • Navigate to node/add/bears_criteria to create 3 criteria
  • Language: English
  • Title: criteria 1
  • Criteria key: criteria_1
  • ID: criteria_1
  • Type: Radio
  • Label criteria 1 label
  • Name: criteria 1 name
  • Values:
  • Yes
  • No
  • Check [x] Has Child
  • Child Dependency Option: Yes
  • Save as Published
  • Language: English
  • Title: criteria 2
  • Criteria key: criteria_2
  • ID: criteria_2
  • Type: Radio
  • Label criteria 2 label
  • Name: criteria 2 name
  • Values:
  • V1
  • V2
  • Check [x] Has Child
  • Child Dependency Option: V1
  • Save as Published
  • Language: English
  • Title: criteria 3
  • Criteria key: criteria_3
  • ID: criteria_3
  • Type: Radio
  • Label criteria 3 label
  • Name: criteria 3 name
  • Values:
  • W1
  • W2
  • Empty [ ] Has Child
  • Save as Published
  • Navigate to node/add/bears_benefit to create a benefit
  • Language: English
  • Title: benefit 1
  • Headline: benefit 1 headline
  • Summary: benefit 1 summary
  • Life Event Forms - check [x] Benefit finder: death of a loved one
  • Agency: agency 1
  • Source Link: https://www.ssa.gov/
  • Benefit Eligibility
  • Criteria Key: criteria 1
  • Label: criteria 1 label
  • Acceptable values: Yes
  • Criteria Key: criteria 2
  • Label: criteria 2 label
  • Acceptable values: V1
  • Criteria Key: criteria 3
  • Label: criteria 3 label
  • Acceptable values: Yes
  • Save as Published
  • Verify error message
  • Update criteria 3 Acceptable values: W1
  • Verify Generating both draft and published JSON data files
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form Benefit finder: death of a loved one edit page
  • In About you section, add 3 criteria
  • Criteria Key: criteria 1
  • Legend: criteria 1 legend
  • Hint: criteria 1 hint
  • Error Message: criteria 1 error
  • Add criteria 2 as criteria 1 child
  • Criteria Key: criteria 2
  • Legend: criteria 2 legend
  • Hint: criteria 2 hint
  • Error Message: criteria 2 error
  • Add criteria 3 as criteria 2 child
  • Criteria Key: criteria 3
  • Legend: criteria 3 legend
  • Hint: criteria 3 hint
  • Error Message: criteria 3 error
  • Save as Published
  • Verify error message
  • Remove criteria 3
  • Save as Published
  • Verify Generating both draft and published JSON data files
  • Navigate to benefit-finder/api/life-event/death
  • Verify criteria 1 and criteria 2 in JSON data
  • Navigate to benefit-finder/death
  • Hard refresh web browser
  • Click Start finding benefits
  • Verify criteria 1 element
  • Select Yes and verify criteria 2 element open
  • Select No and verify criteria 2 element closed
  • Select criteria 1 Yes
  • Select criteria 2 V1
  • Fill other form elements to get into Get your results page
  • Get into "Benefits you did not qualify for" page
  • Find the benefit "Benefit 1" to open
  • Verify "Benefit 1" information
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Change Time Estimate, for example "4-8 minutes"
  • Save as Draft
  • Verify Generating draft JSON data files
  • Navigate to benefit-finder/api/life-event/death?mode=draft
  • Verify updated timeEstimate
  • Navigate to benefit-finder/death?mode=draft
  • Hard refresh web browser
  • Verify updated Estimated time

a11y Improvements

Skip to main is breaking on tab enter #2065

Test reset focus, skip-to-h1 working

  • navigate to /death
  • tab into skip to main element
  • CLICK enter
  • Expect h1 to be focused
  • CLICK "Next"
  • tab into skip to main element
  • CLICK enter
  • Expect h1 to be focused

Test hash anchor in view

  • navigate to /death
  • navigate to first step
  • CLICK "Next"
  • CLICK first error
  • expect hash in url to update
  • expect hash to focus

Announce Web Page Title Changes to Screen Reader Users #1904

  • enable voice over
  • navigate to /death
  • expect to hear page title announced
  • navigate through the app, for each route - expect to hear page title announced
  • navigate through the app, for each route - expect to see the page title change

design Improvements

Color Updates from USA.gov AUDIT #2073

  • ensure the following changes have been made
Screenshot 2025-01-29 at 9 52 10 AM

gchi25 and others added 30 commits January 8, 2025 19:55
…s' of github.com:GSA/px-benefit-finder into 2058-firefox-hash-bug-fix
Co-authored-by: Scott Queen <scott.queen@contractor.bixal.com>
PXBF-1934-client-router-tests: Add Navigation Tests for Life Events Workflow
@scottqueen-bixal scottqueen-bixal self-assigned this Feb 6, 2025
@scottqueen-bixal scottqueen-bixal added this to the v0.10.0.beta.1 milestone Feb 6, 2025
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review February 6, 2025 21:00
Copy link
Contributor

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Worked as expected.

@scottqueen-bixal scottqueen-bixal merged commit 0f23d06 into main Feb 6, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants