-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.10.0 (Sprint 50) #2100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2055 gtm debug script
…s' of github.com:GSA/px-benefit-finder into 2058-firefox-hash-bug-fix
…uses bug in firefox browser history
2058 firefox hash bug fix
Co-authored-by: Scott Queen <scott.queen@contractor.bixal.com>
1904 polite a11y page titles
2065 fix skip to h1 tab order
PXBF-1934-client-router-tests: Add Navigation Tests for Life Events Workflow
… child required for testing
PXBF-2088-life-event-form-error-message
2089 fix nested child errors
PXBF-2080-remove-criteria-type-boolean
PXBF-2074-update-usagov-colors: updated color adjustments
2094 update package
PXBF-1904-polite-a11y-page-titles: update a11y title content
PXBF-2039-phpstan-fixes
…GSA/px-benefit-finder into 2065-fix-skip-to-h1-tab-order
PXBF-2065-fix-skip-to-h1-tab-order: update name space
gchi25
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related Github Issue
Application Improvements
Nested criteria not open as expected #2086
Clicking Back buttons on Firefox browser after entering required fields on ‘death of a loved one’ add an extra route with # on ‘about-the-deceased’ route #2058
child criteria is required cause error #2089
Custom Module Improvements
Remove boolean type of criteria #2080
Life event form criteria error message not showing in JSON data #2088
PHPStan error fixing #2039
a11y Improvements
Skip to main is breaking on tab enter #2065
Announce Web Page Title Changes to Screen Reader Users #1904
design Improvements
Color Updates from USA.gov AUDIT #2073
Detailed Testing steps
Application Improvements
Nested criteria not open as expected, under Date field types #2086
/disability
, create a child criteria with the child dependency value of>=18years
expected:
Screen.Recording.2025-01-27.at.5.48.53.PM.mov
Clicking Back buttons on Firefox browser after entering required fields on ‘death of a loved one’ add an extra route with # on ‘about-the-deceased’ route #2058
child criteria is required cause error #2089
Detailed Testing steps
/disability
, create a child criteria with the child dependency value of>=18years
expected:
Screen.Recording.2025-01-29.at.8.46.51.AM.mov
Custom Module Improvements
Remove boolean type of criteria #2080
http://localhost
admin/content?combine=&type=bears_criteria&status=All&langcode=All
Life event form criteria error message not showing in JSON data #2088
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
benefit-finder/disability
Next
to "About the applicant" pageNext
PHPStan error fixing #2039
a11y Improvements
Skip to main is breaking on tab enter #2065
Test reset focus,
skip-to-h1
working/death
skip to main
elementskip to main
elementTest hash anchor in view
/death
Announce Web Page Title Changes to Screen Reader Users #1904
/death
design Improvements
Color Updates from USA.gov AUDIT #2073