Convert custom snapshot system to jest snapshots #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to properly generate snapshots using
CRAMJS_REWRITE_EXPECTED_DATA=true yarn test
, running twice generated snapshot failuresAs an alternative, there are built-in jest snapshots
This PR does no source code changes, just test changes, so should safely port over
The snapshots are fairly large, and the large dump.test.ts file is actually split into two files to avoid the github limit of 100mb. there is no concept of compressed jest snapshots, and it would limit snapshot effectiveness potentially to limit amount of data snapshotted, so this just stays the course