Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RRTMGP v1.7, GEOSradiation_GridComp v1.8.0 #759

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 29, 2024

This is a meta-PR for updating the components in GEOSgcm to use RRTMGP v1.7 which requires an updated GEOSradiation_GridComp as well:

To run RRTMGP v1.7 you also need a change in GEOSgcm_App currently in a PR: GEOS-ESM/GEOSgcm_App#585

This is zero-diff for RRTMG runs, only changes RRTMGP runs.

Note also that RRTMGP v1.7 can be run in Single Precision mode with the CMake option:

-DRRTMGP_SINGLE_PRECISION=ON

Tests show that single-precision RRTMGP is about 10-20% faster than DP. But, for now we are keeping the default build to be double precision by default until further testing. Per @dr0cloud:

I have noticed around a -0.15W/m2 difference in global OSR in SP mode, but individual clouds can be -2 W/m2 or more.


Updates from GEOSradiation_GridComp v1.7

The above v1.8 tag also brings along updates from v1.7. As listed in #756, this also has effects.

The first is a small change needed for ongoing OceanBioGeoChem work (#28). To use this completely needs updates in GEOSgcm_GridComp and GOCART. Contact @mfmehari for more information.

The second is an update for on-going validation of RRTMGP (#33). This adds a new CMake option, ENABLE_SOLAR_RADVAL which is default OFF. Enabling it will enable many new exports for validation purposes.

This update is non-zero-diff for RRTMGP but that is not run by default currently. For RRTMG they are either zero-diff or 'truncation zero-diff', but these changes should only affect diagnostic outputs. That said, the Solar Internal Restart will have some changes (see below) but the overall state of the model is zero-diff with RRTMG:

  • Metadata changes (long_name)
    • CLDHISW: "high-level_cloud_area_fraction_rrtmg_sw_REFRESH" → "high-level_cloud_area_fraction_RRTMG_P_SW_REFRESH"
    • CLDLOSW: "low-level_cloud_area_fraction_rrtmg_sw_REFRESH" → "low-level_cloud_area_fraction_RRTMG_P_SW_REFRESH"
    • CLDMDSW: "mid-level_cloud_area_fraction_rrtmg_sw_REFRESH" → "mid-level_cloud_area_fraction_RRTMG_P_SW_REFRESH"
    • CLDTTSW: "total_cloud_area_fraction_rrtmg_sw_REFRESH" → "total_cloud_area_fraction_RRTMG_P_SW_REFRESH"
  • Removed fields
    • TAUHIPAR
    • TAULOPAR
    • TAUMDPAR
    • TAUTTPAR
  • Added fields
    • COTDENHIPAR
    • COTDENLOPAR
    • COTDENMDPAR
    • COTDENTTPAR
    • COTHIPAR
    • COTLOPAR
    • COTMDPAR
    • COTTTPAR
    • COTNUMHIPAR
    • COTNUMLOPAR
    • COTNUMMDPAR
    • COTNUMTTPAR

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 29, 2024
@mathomp4 mathomp4 requested a review from dr0cloud February 29, 2024 15:59
@mathomp4 mathomp4 self-assigned this Feb 29, 2024
dr0cloud
dr0cloud previously approved these changes Feb 29, 2024
@mathomp4 mathomp4 changed the title Update to RRTMGP v1.7 Update to RRTMGP v1.7, GEOSradiation_GridComp v1.8.0 Mar 1, 2024
@mathomp4 mathomp4 marked this pull request as ready for review March 1, 2024 17:23
@mathomp4 mathomp4 requested a review from a team as a code owner March 1, 2024 17:23
@sdrabenh sdrabenh merged commit 00c19c2 into main Mar 1, 2024
9 checks passed
@sdrabenh sdrabenh deleted the feature/pnorris/RRTMGP_v1.7 branch March 1, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants