Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_u256 for U128 #6951

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Add as_u256 for U128 #6951

merged 6 commits into from
Feb 25, 2025

Conversation

SwayStar123
Copy link
Collaborator

@SwayStar123 SwayStar123 commented Feb 24, 2025

Description

Adds the conversion helper for U128

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 marked this pull request as ready for review February 24, 2025 06:59
@SwayStar123 SwayStar123 requested review from a team as code owners February 24, 2025 06:59
@SwayStar123 SwayStar123 enabled auto-merge (squash) February 24, 2025 12:51
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against having an own method for this, but why not just implement From<U128>?

@SwayStar123
Copy link
Collaborator Author

Not against having an own method for this, but why not just implement From<U128>?

impl From<U128> for u256 {

We have that already. This is just to ensure consistency as we have as_x functions for all other upcasts

Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense.

@SwayStar123 SwayStar123 merged commit a090937 into master Feb 25, 2025
40 checks passed
@SwayStar123 SwayStar123 deleted the add-as-u256-for-u128 branch February 25, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants