Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nft list getting cut off #1829

Merged
merged 15 commits into from
Feb 12, 2025
Merged

fix: nft list getting cut off #1829

merged 15 commits into from
Feb 12, 2025

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Feb 11, 2025 •
edited
Loading

Summary

  • Added a general loading state for the entire NFT list for when the account data is still loading
  • Fixed NFT image collapsible loading state not matching the sizes of NFT images later displayed
  • Fixed NFT Image list getting cut off

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@arthurgeron arthurgeron marked this pull request as ready for review February 11, 2025 18:12
@arthurgeron arthurgeron marked this pull request as draft February 11, 2025 19:07
@arthurgeron arthurgeron marked this pull request as ready for review February 11, 2025 19:13
@LuizAsFight
Copy link
Contributor

LuizAsFight commented Feb 12, 2025 •
edited
Loading

needs to fix on NFT tab loading , this was on zip file from preview link

image

@LuizAsFight LuizAsFight merged commit 7236697 into master Feb 12, 2025
26 of 27 checks passed
@LuizAsFight LuizAsFight deleted the ag/fix/fe-1328 branch February 12, 2025 03:48
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Merged
LuizAsFight pushed a commit that referenced this pull request Feb 12, 2025
@github-actions
ci(changesets): versioning packages (#1838)
b56f7b1 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to master, this PR will be updated.


# Releases
## @fuels/playwright-utils@0.48.1



## fuels-wallet@0.48.1

### Patch Changes

- [#1829](#1829)
[`72366976`](7236697)
Thanks [@arthurgeron](https://github.com/arthurgeron)! - fix: nft list
getting cut off

-   Updated dependencies \[]:
    -   @fuel-wallet/connections@0.48.1
    -   @fuels/playwright-utils@0.48.1

## @fuel-wallet/connections@0.48.1



## @fuel-wallet/types@0.48.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LuizAsFight LuizAsFight mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helciofranco helciofranco helciofranco left review comments

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add loading state to NFT tab
3 participants
@arthurgeron @LuizAsFight @helciofranco