Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: backport max fee fix to LTS 0.70 #1592

Merged
merged 5 commits into from
Feb 4, 2025
Merged

bug: backport max fee fix to LTS 0.70 #1592

merged 5 commits into from
Feb 4, 2025

Conversation

segfault-magnet
Copy link
Contributor

Cherry picked the last 3 commits of master onto lts/v0.70 in order to backport the fix.

The only change is the downgrade of 0.41.3 to 0.41.0 so that we don't introduce a breaking change in this backport.

Release notes

In this release, we:

  • added max fee estimation tolerance to ScriptCallHandler's convert_into_loader to reduce the occurrence of invalid max fees.

Summary

ScriptCallHandler::convert_into_loader and Executable::upload_blob now use the default max fee estimation tolerance when building the blob tx. This should lessen the occurrence of invalid max fees due to using a different amount of coins than what we estimated with.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

hal3e and others added 4 commits January 30, 2025 20:36
@hal3e @segfault-magnet
fix: bump fuel-core to 0.41.3 and fix test (#1584)
c39edd3 
closes: #1579 and
#1580
# Summary
Bump `fuel-core` to `0.41.3` and fix ignored tests.
@hal3e @segfault-magnet
chore: bump forc to 0.66.6 (#1585)
b1e0b13
@segfault-magnet
bug: script/predicate blob upload now uses the default max fee estima…
0365c57 
…tion tolerance (#1590)

because the gas price horizon no longer increases the price and this makes the max fee estimation more sensitive to extra cost due to using more coins than what we estimated with.
@segfault-magnet
don't increase the minimum version as not to cause a breaking change
90bfd05
@segfault-magnet segfault-magnet added the bug Something isn't working label Jan 30, 2025
@segfault-magnet segfault-magnet self-assigned this Jan 30, 2025
@segfault-magnet segfault-magnet merged commit d5b05b3 into lts/v0.70 Feb 4, 2025
45 checks passed
@segfault-magnet segfault-magnet deleted the bug/patch_max_fee branch February 4, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MujkicA MujkicA MujkicA approved these changes

@hal3e hal3e hal3e approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@segfault-magnet segfault-magnet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segfault-magnet @MujkicA @hal3e