fix!: encoding capacity overflow #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
digorithm
requested changes
Jan 17, 2024
digorithm
requested changes
Feb 8, 2024
packages/fuels-code-gen/src/program_bindings/abigen/bindings/function_generator.rs
Show resolved
Hide resolved
hal3e
requested changes
Feb 11, 2024
packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/script.rs
Outdated
Show resolved
Hide resolved
packages/fuels-code-gen/src/program_bindings/abigen/bindings/script.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: hal3e <git@hal3e.io>
MujkicA
previously approved these changes
Feb 13, 2024
segfault-magnet
previously approved these changes
Feb 13, 2024
packages/fuels-code-gen/src/program_bindings/abigen/configurables.rs
Outdated
Show resolved
Hide resolved
iqdecay
dismissed stale reviews from segfault-magnet, MujkicA, and hal3e
via
f6709bc
…les.rs Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
segfault-magnet
approved these changes
Feb 13, 2024
hal3e
approved these changes
Feb 13, 2024
MujkicA
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capacity overflowwhile encoding param types #1228 by adding theEncoderConfigsimilarly to what was done in bug: fix for memory issue #1066.call()orsimulate()is called on contract or script calls.BREAKING CHANGE:
Configurablesstructs now need to be instantiated through a::new(encoder_config)or::default()method.Configurables::with_some_string_config(some_string)methods now return aResult<Configurables>instead ofConfigurables.Predicates::encode_datanow returns aResult<UnresolvedBytes>instead ofUnresolvedBytes.PredicateEncoderstructs must be instantiated through a::new(encoder_config)or::default()method.