use sha256 sum #20
Open
use sha256 sum #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrianinsaval |
|
I'll re-run the failed checks after post-merge build of https://github.com/FreeCAD/FreeCAD-Bundle/pull/362 completes. |
|
@looooo It appears there's a Jinja expansion error due to |
adrianinsaval
requested changes
Dec 31, 2024
recipe/increase_build_number.py
Outdated
| response.raise_for_status() | ||
| sha256 = response.content.decode('utf-8') | ||
| print(f"set sha256: {sha256}") | ||
| text = re.sub(r"(?<={% set sha256 = )\d+", str(sha256), text) |
There was a problem hiding this comment.
I think this regex here is not correct as it is searching for digits only while the sha256sum also has letters (and looks like it needs quotes surrounding it)
Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>
Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>
|
sry didn't want to trigger ci's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.