Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twir 1.1.0 #214

Merged
merged 5 commits into from
May 16, 2024
Merged

Twir 1.1.0 #214

merged 5 commits into from
May 16, 2024

Conversation

crashmax-dev
Copy link
Contributor

@crashmax-dev crashmax-dev commented Apr 13, 2024

Add badges api, refactor.

@SirStendec
Copy link
Collaborator

Sorry for the delay.

@SirStendec SirStendec merged commit 775d7a2 into FrankerFaceZ:master May 16, 2024
1 check passed
@crashmax-dev crashmax-dev deleted the feat/twir-api-badges branch May 16, 2024 20:09
@crashmax-dev
Copy link
Contributor Author

@SirStendec thanks!

Can you help? I got an error on the production, while in dev everything works.

image

this.settings.getChanges(SETTING_KEYS.userBadges, enabled => {
this.parent.badges.updateSettingBadges(enabled);
});

@SirStendec
Copy link
Collaborator

So, looking at this, something about the code minifier is mangling the names of your classes, which causes FFZ to inject them with unexpected variable names if you haven't manually specified which variable name to use.

I believe this behavior is triggered because you have multiple classes named Badges, but ultimately that doesn't matter. The easiest fix would be to just change your inject(thing) calls to injectAs(name, thing), I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants