luigi's mansion themed board

[Artamone]

added a luigi's mansion themed board to use my luigi's mansion background

[Sophilautia]

So it's been a while since I've singed off on a PR, I wanna introduce some more checks for the author to sign off on before accepting a PR, so I'm gonna put a checklist in here for you to go over. You don't necessarily have to fill out all of these, but they will all need to be filled out before it can be accepted into a stable build of CSWT. They're vaguely sorted in order of importance.

• Board passes validation script

• Files are in correct folders

• All FRBs pass possible paths check (under 70 iirc)

• All paths are functioning as intended (including doors and yoshi lifts and magmalices)

• There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)

• All backstreet destinations are as intended

• YAML is formatted correctly

• YAML has author and changelog

• YAML has Author's URL (or doesn't have one if not wanted)

• Files and folders have no special characters / spaces / capitalisations

• Map icon is included, follows existing template, and is correctly implemented in yaml

• Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)

• Music is properly implemented and uploaded to server

• All looping music is looping, and all non-looping music isn't looping

• There are exactly 64 venture cards

• IF Venture card 45 is active, then there must be both an arcade & take a break square

• IF Venture card 125 is active, then there must be both an arcade & boon square

• There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive

• Max dice roll is below 10

• You can't travel between three sets of doors in one roll

---

IF max dice roll is 9:

• There are no doors.

---

IF max dice roll is 8:

• There are no two-way doors

• You can't travel between two sets of doors in one roll

---

IF max dice roll is 7:

• You can't travel between two sets of doors in one roll

• Venture card 87 is inactive

---

IF max dice roll is 6:

• Venture card 87 is inactive

• Venture card 115 is inactive

---

• Balloonport test has been completed on emulator OR console

• Balloonport test has been completed on console

• At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)

• A full game of the board has been played by humans

• All music has been tested and volumes are OK

[Sophilautia]

If you have any questions about these, let me know, I'd appreciate feedback on this process since it's my first time trying it really.

[Artamone]

So it's been a while since I've singed off on a PR, I wanna introduce some more checks for the author to sign off on before accepting a PR, so I'm gonna put a checklist in here for you to go over. You don't necessarily have to fill out all of these, but they will all need to be filled out before it can be accepted into a stable build of CSWT. They're vaguely sorted in order of importance.

• Board passes validation script
• Files are in correct folders
• All FRBs pass possible paths check (under 70 iirc)
• All paths are functioning as intended (including doors and yoshi lifts and magmalices)
• There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
• All backstreet destinations are as intended
• YAML is formatted correctly
• YAML has author and changelog
• YAML has Author's URL (or doesn't have one if not wanted)
• Files and folders have no special characters / spaces / capitalisations
• Map icon is included, follows existing template, and is correctly implemented in yaml
• Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
• Music is properly implemented and uploaded to server
• All looping music is looping, and all non-looping music isn't looping
• There are exactly 64 venture cards
• IF Venture card 45 is active, then there must be both an arcade & take a break square
• IF Venture card 125 is active, then there must be both an arcade & boon square
• There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
• Max dice roll is below 10
• You can't travel between three sets of doors in one roll

IF max dice roll is 9:

• There are no doors.

IF max dice roll is 8:

• There are no two-way doors
• You can't travel between two sets of doors in one roll

IF max dice roll is 7:

• You can't travel between two sets of doors in one roll
• Venture card 87 is inactive

IF max dice roll is 6:

• Venture card 87 is inactive

• Venture card 115 is inactive

• Balloonport test has been completed on emulator OR console

• Balloonport test has been completed on console

• At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)

• A full game of the board has been played by humans

• All music has been tested and volumes are OK

[Ennesan]

The background zip file and the background name specified in the yaml do not match, so we cannot build with this board included. Also, it seems that some of the music files set up in yaml are not in the background zip file.
Edit the background zip file or yaml.

[Sophilautia]

The background zip file and the background name specified in the yaml do not match, so we cannot build with this board included.

Oh, nice catch. @Artamone will need to fix this.

Also, the music file that is set in yaml does not seem to be in the background zip file.

Hm, I just updated the music so it should be okay. There might be a cache issue.

[Sophilautia]

I have created an invalidation, so it should fix the caching issue. Can you confirm that the background file has the correct music files now? @Ennesan

[Ennesan]

Link to the zip file used to check the contents of the yaml and background zip files for correctness
https://nikkums.io/cswt/Backgrounds/LuigisMansion.background.zip

[Ennesan]

I checked by editing the background zip file name and it does not seem to contain "maintheme.brstm".

[Ennesan]

無効化を作成したので、キャッシュの問題は解決されるはずです。 バックグラウンド ファイルに正しい音楽ファイルが含まれていることを確認できますか? @Ennesan
@Sophilautia
I confirmed that it is up-to-date.

[Ennesan]

Please rename the background zip file to "mansion.background.zip".

[Ennesan]

@Sophilautia You may have already done this, but I will pass it on.
Rename the cmpres file name and the scene file name to LuigisMansion and upload it to nikkums.io.

[Ennesan]

@Sophilautia
Edited file to work correctly with background name LuigiMansion.
It has been tested and works correctly.
I am sending you a link to the zip file here.
https://drive.google.com/u/0/uc?id=1SF_UsA3-fuyxqsxU29DwgrUoOg9D5Ysb&export=download

[Ennesan]

@Artamone The board icon file name is the same as the Rainbow Road MKWii file name; when I build to include Rainbow Road MKWii and Luigi's Mansion, the icon is not the Luigi's Mansion icon. Therefore, please rename the file with the Luigi's Mansion icon. Also, remember to edit the mapicon part of the yaml to the new filename.

[Sophilautia]

I'm really confused... You said the zip file needed to have the scene and cmpres files renamed to LuigisMansion, but they already are. See here.

But yes, you are right about the map icon name. Artamone needs to change that.

[Sophilautia]

@Artamone This is just waiting on you to update the map icon names

[Artamone]

it should be good now