Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 addresses cannot connect #18

Closed
Steve-Mcl opened this issue Jan 16, 2023 · 4 comments · Fixed by #19
Closed

IPv6 addresses cannot connect #18

Steve-Mcl opened this issue Jan 16, 2023 · 4 comments · Fixed by #19
Labels
bug Something isn't working
Milestone

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

If user has specified !Pv6 address, WS (via MQTT.js) throws an error

Full details in MQTT.JS issue raised here: mqttjs/MQTT.js#1569

Expected Behavior

IPv6 addresses should connect

Steps To Reproduce

  • Set broker config in flowforge.yml to use ::1 (or any other IPv6 address)
  • Start FlowForge
  • regenerate a device credentials, copy to device & run the agent

example yml section for project nodes MQTT Broker Configuration:

#################################################
# MQTT Broker Configuration                     #
#################################################

broker:
  ## Internal url used by the platform to connect to the broker
  url: mqtt://[::1]:9883
  ## External url used by devices to connect to the broker, if different
  public_url: ws://[::1]:9884

Environment

  • FlowForge version: 1.x-git
  • Node.js version: 16
  • npm version: 8
  • Platform/OS: Windows/Linux
  • Browser:
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Jan 16, 2023
@Steve-Mcl Steve-Mcl moved this to Review in 🛠 Development Jan 16, 2023
@Steve-Mcl Steve-Mcl modified the milestone: 1.3 Jan 16, 2023
@Steve-Mcl Steve-Mcl added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Jan 16, 2023
@Steve-Mcl Steve-Mcl moved this from Review to Todo in 🛠 Development Jan 16, 2023
@Steve-Mcl Steve-Mcl removed this from the 1.3 milestone Jan 16, 2023
@Steve-Mcl Steve-Mcl moved this to Review in 🛠 Development Jan 16, 2023
@Steve-Mcl Steve-Mcl added this to the 1.3 milestone Jan 16, 2023
@knolleary knolleary moved this from Review to Verify in 🛠 Development Jan 16, 2023
@Steve-Mcl
Copy link
Contributor Author

Tested localfs, windows and linux - OK.

@hardillb is it possible to adjust an IPv4 to IPv6 on staging (or your own k8s) to test this pls?

@hardillb
Copy link
Contributor

Enabling IPv6 on AWS would not be useful in this case, because access is always going to be via a Hostname not a bare IP address. It has to be because the hostname needs to match the TLS certificate.

@Steve-Mcl
Copy link
Contributor Author

ok, so local test only is all we can achieve at this point.

@Steve-Mcl Steve-Mcl moved this from Verify to Done in 🛠 Development Jan 18, 2023
@hardillb
Copy link
Contributor

And localfs is the only place bare IP addresses should ever be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants