Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 addresses cannot connect #50

Closed
Steve-Mcl opened this issue Jan 16, 2023 · 1 comment · Fixed by #51
Closed

IPv6 addresses cannot connect #50

Steve-Mcl opened this issue Jan 16, 2023 · 1 comment · Fixed by #51
Labels
bug Something isn't working
Milestone
1.3

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

If user has specified !Pv6 address, WS (via MQTT.js) throws an error

Full details in MQTT.JS issue raised here: mqttjs/MQTT.js#1569

Expected Behavior

IPv6 addresses should connect

Steps To Reproduce

  • Set broker config in flowforge.yml to use ::1 (or any other IPv6 address)
  • Start FlowForge
  • regenerate a device credentials, copy to device & run the agent

example yml section for project nodes MQTT Broker Configuration:

#################################################
# MQTT Broker Configuration                     #
#################################################

broker:
  ## Internal url used by the platform to connect to the broker
  url: mqtt://[::1]:9883
  ## External url used by devices to connect to the broker, if different
  public_url: ws://[::1]:9884

Environment

  • FlowForge version: 1.x-git
  • Node.js version: 16
  • npm version: 8
  • Platform/OS: Windows/Linux
  • Browser:
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Jan 16, 2023
@Steve-Mcl Steve-Mcl mentioned this issue Jan 16, 2023
Merged
8 tasks
@Steve-Mcl Steve-Mcl added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Jan 16, 2023
@Steve-Mcl Steve-Mcl moved this to Review in 🛠 Development Jan 16, 2023
@Steve-Mcl Steve-Mcl added this to the 1.3 milestone Jan 16, 2023
@knolleary knolleary moved this from Review to Verify in 🛠 Development Jan 16, 2023
@Steve-Mcl
Copy link
Contributor Author

Verified locally.
Cannot test in staging - see comment: FlowFuse/nr-project-nodes#18 (comment)

@Steve-Mcl Steve-Mcl moved this from Verify to Done in 🛠 Development Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
🛠 Development
Archived in project
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Ensure ws URLs with ipv6 address can connect MQTT FlowFuse/device-agent
1 participant
@Steve-Mcl