Skip to content

Commit

Permalink
fix: Labels made observability metrics unusable
Browse files Browse the repository at this point in the history
In traffic recording updates the labels were added to JFR events and this way they also got into the observability metrics. This made metrics with very high cardinality and overloads the server. We need to reconsider the approach to labels that get incorporated into the metrics.

Refs: #800
  • Loading branch information
novoj committed Feb 11, 2025
1 parent 256a3a0 commit bceb1af
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* | __/\ V /| | || (_| | |_| | |_) |
* \___| \_/ |_|\__\__,_|____/|____/
*
* Copyright (c) 2024
* Copyright (c) 2024-2025
*
* Licensed under the Business Source License, Version 1.1 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -59,7 +59,6 @@ public class FinishedEvent extends AbstractQueryEvent {

@Label("Labels")
@Description("Zero or more client labels associated with the query. Labels are delimited by comma, label consists of name and value separated by equals sign.")
@ExportMetricLabel
private final String labels;

@Label("Query planning duration in milliseconds")
Expand Down

0 comments on commit bceb1af

Please sign in to comment.