Fix #3406: Change default of DeserializationFeature.FAIL_ON_TRAILING_TOKENS to true
#4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_TRAILING_TOKENS` to `true`
JooHyukKim
commented
Jan 29, 2025
src/test/java/tools/jackson/databind/jsontype/PolymorphicDeserErrorHandlingTest.java
Outdated
Show resolved
Hide resolved
src/test/java/tools/jackson/databind/jsontype/TestPolymorphicWithDefaultImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/tools/jackson/databind/jsontype/ext/ExternalTypeIdTest.java
Outdated
Show resolved
Hide resolved
|
Oh wow! I should have looked deeper into failures -- exception message mislead me to think there was a real problem. Still, I think error handling for incomplete content seems brittle. Let me look at this for a bit. Thank you for diagnosing the immediate issue! |
|
Ahhhhh! I get it now -- the error report is making wrong assumption; need to file a separate issue against |
|
Thank you again @JooHyukKim !!! This was excellent, I merged fixes to 2.x, and merged the other PR so can close this now. Also filed for follow-up work wrt confusing error message that spooked me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended version of #4902 @cowtowncoder you may want to refer to.
Here I just fixed JSON syntax error in the failing tests from #4902.
The JSON syntax errors seem unrelated to the tests.