fix: lint, test

cd: update configmap to point to new plugin URL
FZJ-INM1-BDA · Oct 17, 2024 · 64df3d7 · 64df3d7
1 parent aeda825
commit 64df3d7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.helm/adhoc/configmap-siibra-explorer.yml b/.helm/adhoc/configmap-siibra-explorer.yml
@@ -3,7 +3,7 @@ data:
   SIIBRA_CACHEDIR: /siibra-api-volume
   HBP_DISCOVERY_URL: "https://iam.ebrains.eu/auth/realms/hbp"
   REDIS_ADDR: "cache-redis-service"
-  V2_7_PLUGIN_URLS: "https://siibra-jugex.apps.tc.humanbrainproject.eu/viewer_plugin/manifest.json;https://ngpy.apps.hbp.eu/viewer_plugin/manifest.json"
+  V2_7_PLUGIN_URLS: "https://siibra-jugex.apps.tc.humanbrainproject.eu/viewer_plugin/manifest.json;https://neurogenpy.apps.ebrains.eu/viewer_plugin/manifest.json"
   LOGGER_DIR: "/sxplr-log"
   OVERWRITE_API_ENDPOINT: https://siibra-api-prod.apps.tc.humanbrainproject.eu/v3_0
   OVERWRITE_SPATIAL_ENDPOINT: 'https://siibra-spatial-backend.apps.tc.humanbrainproject.eu'

diff --git a/src/freeModeModule/freemode-ui/freemode-ui.component.ts b/src/freeModeModule/freemode-ui/freemode-ui.component.ts
@@ -1,4 +1,4 @@
-import { Component, PACKAGE_ROOT_URL } from "@angular/core";
+import { Component } from "@angular/core";
 import { AtlasWorkerService } from "src/atlasViewer/atlasViewer.workerService.service";
 import { MatSnackBar } from "src/sharedModules";
 
@@ -30,7 +30,7 @@ export class FreeModeUIComponent {
        * The emitted value does not affect the region selection
        * the region selection is taken care of in nehubaContainer
        */
-
+      /* eslint-disable-next-line no-empty */
       if (arg === 'select') {
       }
     }
@@ -117,7 +117,7 @@ export class FreeModeUIComponent {
       },
       transfers: [buf],
     })
-    const { buffer, meta } = result
+    const { buffer } = result
     const url = URL.createObjectURL(new Blob([buffer]))
     const config = this.#getCfg(`nifti://${url}`)
     createNehubaViewer(config)

diff --git a/src/routerModule/effects.spec.ts b/src/routerModule/effects.spec.ts
@@ -10,6 +10,7 @@ import { RouterEffects } from "./effects"
 import { STATE_DEBOUNCE_MS } from "./const"
 import { NgZone } from "@angular/core"
 import { take } from "rxjs/operators"
+import { GET_ATTR_TOKEN } from "src/util/constants"
 
 let mockRouter: any 
 
@@ -67,6 +68,10 @@ describe("> effects.ts", () => {
           {
             provide: APP_BASE_HREF,
             useValue: '/'
+          },
+          {
+            provide: GET_ATTR_TOKEN,
+            useValue: (arg: string) => null
           }
         ]
       })

diff --git a/src/routerModule/effects.ts b/src/routerModule/effects.ts
@@ -180,7 +180,7 @@ export class RouterEffects {
     private store: Store<MainState>,
     private zone: NgZone,
     @Inject(APP_BASE_HREF) private baseHref: string,
-    @Inject(GET_ATTR_TOKEN) private getattr: (attrName: string) => string
+    @Inject(GET_ATTR_TOKEN) private getattr: (attrName: string) => undefined|null|string
   ){
 
   }