Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connect): internal refactoring to make connect code more organized & extensible #3680

Merged
merged 32 commits into from
Jan 16, 2025

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…

3b5901a
Select commit
Loading
Failed to load commit list.
Merged

refactor(connect): internal refactoring to make connect code more organized & extensible #3680

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…
3b5901a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 15, 2025 in 0s

69.44% of diff hit (target 77.79%)

View this Pull Request on Codecov

69.44% of diff hit (target 77.79%)

Annotations

Check warning on line 183 in src/daft-connect/src/connect_service.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/connect_service.rs#L183 

Added line #L183 was not covered by tests

Check warning on line 77 in src/daft-connect/src/functions/core.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/functions/core.rs#L77 

Added line #L77 was not covered by tests

Check warning on line 95 in src/daft-connect/src/functions/core.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/functions/core.rs#L95 

Added line #L95 was not covered by tests

Check warning on line 102 in src/daft-connect/src/functions/core.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/functions/core.rs#L102 

Added line #L102 was not covered by tests

Check warning on line 70 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L68-L70 

Added lines #L68 - L70 were not covered by tests

Check warning on line 76 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L72-L76 

Added lines #L72 - L76 were not covered by tests

Check warning on line 84 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L79-L84 

Added lines #L79 - L84 were not covered by tests

Check warning on line 87 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L86-L87 

Added lines #L86 - L87 were not covered by tests

Check warning on line 118 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L118 

Added line #L118 was not covered by tests

Check warning on line 122 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L122 

Added line #L122 was not covered by tests

Check warning on line 126 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L126 

Added line #L126 was not covered by tests

Check warning on line 144 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L144 

Added line #L144 was not covered by tests

Check warning on line 147 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L147 

Added line #L147 was not covered by tests

Check warning on line 155 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L155 

Added line #L155 was not covered by tests

Check warning on line 171 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L171 

Added line #L171 was not covered by tests

Check warning on line 191 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L191 

Added line #L191 was not covered by tests

Check warning on line 202 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L199-L202 

Added lines #L199 - L202 were not covered by tests

Check warning on line 208 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L205-L208 

Added lines #L205 - L208 were not covered by tests

Check warning on line 211 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L210-L211 

Added lines #L210 - L211 were not covered by tests

Check warning on line 214 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L213-L214 

Added lines #L213 - L214 were not covered by tests

Check warning on line 218 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L216-L218 

Added lines #L216 - L218 were not covered by tests

Check warning on line 222 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L221-L222 

Added lines #L221 - L222 were not covered by tests

Check warning on line 227 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L224-L227 

Added lines #L224 - L227 were not covered by tests

Check warning on line 232 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L230-L232 

Added lines #L230 - L232 were not covered by tests

Check warning on line 236 in src/daft-connect/src/spark_analyzer.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/spark_analyzer.rs#L235-L236 

Added lines #L235 - L236 were not covered by tests
View more details on Codecov