Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic reference implementation for Sign Protocol #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kaiadachi
Copy link

@kaiadachi kaiadachi commented Nov 16, 2024

Description

Added a basic reference implementation to demonstrate the core functionality of Sign Protocol.

Changes

  • Added SignProtocolExample contract with basic schema registration
  • Implemented simple attestation flow
  • Added clear documentation and comments
  • Focused on showing essential features for easy understanding

Why

This reference implementation will help new developers understand how to integrate with Sign Protocol by providing a clear, minimal example.

Test

 forge test      
[⠒] Compiling...
No files changed, compilation skipped

Ran 1 test for test/SignProtocolExample.t.sol:SignProtocolExample
[PASS] test_attestationFlow() (gas: 297192)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 13.47ms (3.51ms CPU time)

Ran 1 test suite in 169.86ms (13.47ms CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

feature/add_sample
feature/add_sample
@boyuanx
Copy link
Contributor

boyuanx commented Nov 23, 2024

@kaiadachi Thank you for this! However, could you resolve the failed check? Thanks again!

@boyuanx boyuanx self-requested a review November 23, 2024 15:59
@kaiadachi kaiadachi force-pushed the feature/add_sample branch 2 times, most recently from c306428 to e41bdd1 Compare November 29, 2024 15:03
@kaiadachi
Copy link
Author

@kaiadachi Thank you for this! However, could you resolve the failed check? Thanks again!

hi! @boyuanx
The CI environment uses bun install, but this doesn't correctly resolve the forge-std GitHub dependency in package.json. Since the remappings reference node_modules, this causes build failures.

you should either:

  1. Use npm install consistently across all environments
  2. Move forge-std management to Forge's lib directory via forge install

Since this project doesn't use lib/, switching from bun install to npm install would be the simplest solution.
0654173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants