Skip to content

[New] Apply blend renderer to hillshade #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 7, 2025

Conversation

des12437
Copy link
Contributor

@des12437 des12437 commented May 3, 2025

Description

This PR implements Apply blend renderer to hillshade in Visualization category.
URL to README: URL

Linked Issue(s)

  • swift/issues/6830

How To Test

Open the sample and adjust the Renderer Settings and verify that the map updates.

Screenshots

apply-blend-renderer-to-hillshade

@des12437 des12437 self-assigned this May 3, 2025
@des12437 des12437 requested review from a team, philium and CalebRas and removed request for a team May 5, 2025 17:38
@des12437 des12437 marked this pull request as ready for review May 5, 2025 17:39
Copy link
Contributor

@philium philium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new Swift source files to the Copy Source Code Files build phase.

@des12437 des12437 requested a review from philium May 6, 2025 18:13
@des12437 des12437 requested a review from philium May 6, 2025 18:54
philium
philium previously approved these changes May 6, 2025
Copy link
Contributor

@philium philium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes!

Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some suggestions and questions

CalebRas
CalebRas previously approved these changes May 7, 2025
@des12437 des12437 merged commit 0f52161 into v.next May 7, 2025
1 check passed
@des12437 des12437 deleted the destiny/Apply-blend-renderer-to-hillshade branch May 7, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants