Feature forms fix

[shubham7109]

Description

PR to patch feature forms sample with sample data changes

Issue

• https://devtopia.esri.com/runtime/kotlin/issues/5307

[markjdugger]

@shubham7109
This fix does not address the defective feature form definition.
If you run the app in this PR and tap on a place, you will see a Feature form editor that has dozens of fields. However, the feature form definition in the web map has only 12 fields:

So...I think you're getting the default feature form, which is not what the sample, I suspect, aims to show. The API Ref for FeatureForm says:

If the feature's com.arcgismaps.mapping.layers.FeatureLayer, com.arcgismaps.data.ArcGISFeatureTable, or the com.arcgismaps.mapping.layers.SubtypeSublayer specific to the feature's com.arcgismaps.data.FeatureSubtype has been authored with a FeatureFormDefinition, then this authored FeatureFormDefinition will be used to create the FeatureForm. If a FeatureFormDefinition is not found, a default definition is generated and used to create the FeatureForm.

[markjdugger]

This fix provides a default feature form definition, instead of the feature form definition specified in the web map's JSON. See my comment above for details.

It's up to you whether you think this is appropriate for the sample.

[markjdugger]

@shubham7109
I checked with Vivian about Swift version of this sample. She has the same results as you: a default feature form that displays all the fields in the table/layer. That's over 90!