Create and edit geometries sample basic implementation #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize the create and edit geometries sample
TADraeseke
reviewed
Jan 16, 2025
...sri/arcgismaps/sample/createandeditgeometries/components/CreateAndEditGeometriesViewModel.kt
Outdated
Show resolved
Hide resolved
...sri/arcgismaps/sample/createandeditgeometries/components/CreateAndEditGeometriesViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/createandeditgeometries/screens/CreateAndEditGeometriesScreen.kt
Outdated
Show resolved
Hide resolved
...sri/arcgismaps/sample/createandeditgeometries/components/CreateAndEditGeometriesViewModel.kt
Outdated
Show resolved
Hide resolved
shubham7109
reviewed
Jan 17, 2025
...sri/arcgismaps/sample/createandeditgeometries/components/CreateAndEditGeometriesViewModel.kt
Outdated
Show resolved
Hide resolved
...tries/src/main/java/com/esri/arcgismaps/sample/createandeditgeometries/screens/ButtonMenu.kt
Outdated
Show resolved
Hide resolved
...tries/src/main/java/com/esri/arcgismaps/sample/createandeditgeometries/screens/ButtonMenu.kt
Outdated
Show resolved
Hide resolved
Cleaner syntax Co-authored-by: TADraeseke <tdraeseke@esri.com>
Implement state hoisting
darryl-lynch
changed the base branch from
v.next
to
dl/create_and_edit_geometries_sample
|
I've changed the base branch to another branch since an effectively incomplete sample should not be going into |
|
Since all comments have been addressed and there are no new comments I am going to merge this into my working branch so I can create a new PR against it for the second stage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic implementation of create and edit geometries sample for early review.
Links and Data
Issues: https://devtopia.esri.com/runtime/kotlin/issues/2921, https://devtopia.esri.com/runtime/kotlin/issues/5231
vTest: https://runtime-kotlin.esri.com/view/all/job/vtest/job/sampleviewer/73/
What To Review
Review like ordinary sample, but also check whether any issues that would hinder addition of rest of features in future. Mostly using the Snap Geometries sample as a basis for function logic. Will fail style checks as README will likely be part of final stage.
How to Test
Run the sample on the sample viewer or the repo.