Cut geometry sample #302
Merged
Cut geometry sample #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darryl-lynch
force-pushed
the
cut_geometry_sample
branch
2 times, most recently
from
583a944 to
ab9bc97
Compare
darryl-lynch
force-pushed
the
cut_geometry_sample
branch
from
ab9bc97 to
5737b4d
Compare
01smito01
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Sample works quite nicely @darryl-lynch. Just a few suggestions & considerations.
samples/cut-geometry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/MainActivity.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
Change order of graphics add so the polyline lays on top of the polygon
01smito01
approved these changes
Jan 15, 2025
| }.toGeometry() | ||
| } | ||
| // get a polygon corresponding to Lake Superior | ||
| private val lakeSuperiorPolygon = makeLakeSuperior() |
There was a problem hiding this comment.
Not 100% sure on the function name here, but I've not got an immediate suggestion.
There was a problem hiding this comment.
I see where you're coming from
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Smith <67012037+01smito01@users.noreply.github.com>
Co-authored-by: Oliver Smith <67012037+01smito01@users.noreply.github.com>
Co-authored-by: Oliver Smith <67012037+01smito01@users.noreply.github.com>
Co-authored-by: Oliver Smith <67012037+01smito01@users.noreply.github.com>
alan-edi
reviewed
Jan 21, 2025
There was a problem hiding this comment.
@darryl-lynch Looks good. A couple of minor quibbles to consider.
Also, a couple of things re the screenshot:
- The Contribution Guide says
Screenshots should not contain the "Licensed for developers" watermarkand points at some license keys that can be used to achieve that. - Personally I'd prefer our screenshots to include significant UI components, in this case the 2 buttons. Here's what I did for one I worked on recently. That said, I'm not sure others have done that consistently.
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
...etry/src/main/java/com/esri/arcgismaps/sample/cutgeometry/components/CutGeometryViewModel.kt
Outdated
Show resolved
Hide resolved
Fix one method level comment being unaligned Add full stop to the end of sentences
I've mostly just been reusing the old screenshots, which contain the watermark and don't have the buttons. There does seem to be inconsistency regarding inclusion of buttons even within the more recently migrated or created samples, though I agree the watermark is not ideal and the guidance is clear on it so I will get a new screenshot without it at least. |
alan-edi
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
@darryl-lynch I'm approving this so as not to delay merging when you're ready. I assume you'll create a screenshot without the watermark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the cut geometry sample from XML to Compose
Links and Data
Issue: https://devtopia.esri.com/runtime/kotlin/issues/4974
vTest: https://runtime-kotlin.esri.com/view/all/job/vtest/job/sampleviewer/70/
What To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.