-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colinanderson/play kml tour compose #287
Merged
Merged
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3ea40b5
Tour can now play
colinanderson 6164dd2
Use flows for status and progress
colinanderson 044dff0
Implement reset, renames etc.
colinanderson b2853bc
Layout and use the flow to detrmine play/pause button
colinanderson 25ac699
Add icons
colinanderson 5ce36d3
Disable/enable reset button
colinanderson 9e473c5
Formatting and don't need to use emit
colinanderson 84e6e9c
Downloade activity
colinanderson 21328e7
Add downlaod activity to manifest
colinanderson 51d5f0d
Use provisioning location
colinanderson 36c0505
Add downloader to metadata
colinanderson 120b781
Readme and metadata
colinanderson 7c5eda4
Change basemap and add comments
colinanderson d4de4e8
Screenshot
colinanderson e9423e0
Clean up
colinanderson 187c004
Replace old implementation with new compose implementation
colinanderson 01c26d2
Add the new files
colinanderson 05c43fd
Manifest
colinanderson 2da0096
Merge branch 'v.next' into colinanderson/play_kml_tour_compose
colinanderson 13b6dff
Update readme and metadata
colinanderson d49c3bf
Update the metadata to hopefully fix PR check
colinanderson 11e52d9
Scene doesn't need to be mutable state
colinanderson c4cc7ef
Code review updates
colinanderson c7a27b3
Fix copyright
colinanderson 779898d
Rename from KML to Kml
colinanderson 6b67e9f
Renames
colinanderson f4b72f5
Disable play/pause button if the tour is not initialized
colinanderson 6cfa664
Renames
colinanderson 065290a
Don't need remember or initial values
colinanderson 173f135
Add end of file
colinanderson 8aacd89
Organize imports
colinanderson 108e401
Be more Kotlin
colinanderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...es/play-kml-tour/src/main/java/com/esri/arcgismaps/sample/playkmltour/DownloadActivity.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd habitually add a newline to the end of the file, though I'm not sure it actually matters here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added