Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Edit features using feature forms #228

Merged
merged 21 commits into from
Aug 22, 2024
Merged

Sample: Edit features using feature forms #228

merged 21 commits into from
Aug 22, 2024

Conversation

shubham7109
Copy link
Collaborator

@shubham7109 shubham7109 commented Jul 26, 2024 •
edited
Loading

Description

PR to include the sample Edit features using feature forms to the Edit and manage data category.

Links and Data

Sample issue: #3714

What To Review

  • Review the code to make sure it is easy to follow like other samples on Android
  • README.md and README.metadata.json files
  • Kotlin Code files

How to Test

Run the sample on the repo.

@shubham7109
init sample
4828121
@shubham7109
Merge branch 'v.next' into shubham/feature-forms
f539e37
@shubham7109
feature form sample init
97e9b98
@shubham7109
Squashed commit of the following:
a1b2bab 
commit 2c0e09b
Merge: 2f0014a 12abc0c
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Jul 24 14:48:49 2024 +0100

    Refactor Show callout sample to use composable geoview (#223)

commit 12abc0c
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Jul 24 12:23:10 2024 +0100

    Update README.md

commit 2f0014a
Merge: 41addc4 9bacbf7
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Jul 24 12:08:49 2024 +0100

    Custom dynamic entity sample callout (#222)

commit 9bacbf7
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Jul 24 10:26:07 2024 +0100

    Update README.md

commit 89eaa2b
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Jul 24 10:23:13 2024 +0100

    PR fixes: remove column from callout and update README

commit fa64afc
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Jul 24 09:44:42 2024 +0100

    metadata fix

commit f7c3609
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Jul 24 09:35:01 2024 +0100

    Update README.md

commit 0b5b7a5
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Jul 24 09:34:26 2024 +0100

    add description and link to toolkit callout

commit 2a85cc7
Merge: 3b3df83 217c139
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 16:33:07 2024 +0100

    pull from origin

commit 3b3df83
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 16:32:28 2024 +0100

    pull from origin

commit a186336
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 16:31:45 2024 +0100

    pull from origin

commit a457f7f
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 16:30:52 2024 +0100

    put dialog composable back into Main Screen

commit 86bb66a
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 15:22:39 2024 +0100

    refactor to use composable geoview

commit 217c139
Merge: a89ab83 41addc4
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:36:27 2024 +0100

    Merge branch 'v.next' into trev8939/dynamicEntityWorking

commit a89ab83
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Jul 23 11:35:48 2024 +0100

    PR fixes

commit 768eacf
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:17:10 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/screens/MainScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit a706fed
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:17:03 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/screens/MainScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit ad8286f
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:16:56 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/screens/MainScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 0536825
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:16:49 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/screens/MainScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit d3fd4ff
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:16:30 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/components/MapViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit fab1a53
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jul 23 11:16:23 2024 +0100

    Update add-custom-dynamic-entity-data-source/src/main/java/com/esri/arcgismaps/sample/addcustomdynamicentitydatasource/components/MapViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit c903247
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Jul 22 17:03:35 2024 +0100

    re-implement filter and use MaterialTheme colors

commit f385d68
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Jul 22 16:12:49 2024 +0100

    add a few comments on state variables

commit 457c77b
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Jul 22 16:09:05 2024 +0100

    update screenshot

commit 687410a
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Jul 22 15:58:13 2024 +0100

    custom callout colours and observation collection canceled on each identify

commit a3d8446
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Jul 22 14:22:30 2024 +0100

    working callout with latest toolkit build

commit 3520754
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Jul 17 15:23:09 2024 +0100

    repro case identified

commit c8f2803
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Jul 17 11:28:25 2024 +0100

    fully working with multiple callouts

commit 02f2143
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Fri Jul 12 16:49:03 2024 +0100

    bug with callout only showing once
@shubham7109
Merge branch 'v.next' into shubham/feature-forms
0b60db5
@shubham7109
added sample optimizations
d7e3a2c
@shubham7109 shubham7109 changed the title Shubham/feature forms Feature forms sample Jul 27, 2024
@shubham7109 shubham7109 self-assigned this Aug 2, 2024
@shubham7109 shubham7109 changed the title Feature forms sample Sample: Edit features using feature forms Aug 13, 2024
@shubham7109 shubham7109 added the New sample New Kotlin sample using ArcGIS Maps SDK label Aug 13, 2024
@shubham7109 shubham7109 marked this pull request as ready for review August 16, 2024 16:50
sorenoid
sorenoid requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@sorenoid sorenoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good @shubham7109 . I have just one question about the README and some small refactoring suggestions.

edit-features-using-feature-forms/README.md Outdated Show resolved Hide resolved
edit-features-using-feature-forms/README.md Outdated Show resolved Hide resolved
...ain/java/com/esri/arcgismaps/sample/editfeaturesusingfeatureforms/components/MapViewModel.kt Outdated Show resolved Hide resolved
...ain/java/com/esri/arcgismaps/sample/editfeaturesusingfeatureforms/components/MapViewModel.kt Outdated Show resolved Hide resolved
@shubham7109 shubham7109 requested a review from sorenoid August 20, 2024 21:40
@shubham7109
Copy link
Collaborator Author

Thanks @sorenoid, ready for your re-review.

sorenoid
sorenoid approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@sorenoid sorenoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shubham7109 shubham7109 requested a review from kaushikrw August 21, 2024 23:47
kaushikrw
kaushikrw requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@kaushikrw kaushikrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well @shubham7109. Just some minor comments below.

edit-features-using-feature-forms/README.md Outdated Show resolved Hide resolved
edit-features-using-feature-forms/README.md Show resolved Hide resolved
...ain/java/com/esri/arcgismaps/sample/editfeaturesusingfeatureforms/components/MapViewModel.kt Outdated Show resolved Hide resolved
...src/main/java/com/esri/arcgismaps/sample/editfeaturesusingfeatureforms/screens/MainScreen.kt Outdated Show resolved Hide resolved
@shubham7109 shubham7109 requested a review from kaushikrw August 22, 2024 16:43
@shubham7109
Copy link
Collaborator Author

Thanks for the review @kaushikrw, added the changes and ready for you.

kaushikrw
kaushikrw approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@kaushikrw kaushikrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shubham7109 shubham7109 merged commit aaebd2b into v.next Aug 22, 2024
1 check passed
@shubham7109 shubham7109 deleted the shubham/feature-forms branch August 22, 2024 16:48
shubham7109 added a commit that referenced this pull request Aug 26, 2024
@shubham7109
Squashed commit of the following:
c2ecdb2 
commit aaebd2b
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Thu Aug 22 09:48:50 2024 -0700

    Sample: `Edit features using feature forms` (#228)

commit c6fdddc
Author: Nour Siwar @ Esri <100004210+NourdotSiwar@users.noreply.github.com>
Date:   Wed Aug 14 17:42:27 2024 -0700

    Fixed issue through adding onLayerViewStatechanged on MapView (#232)

commit 7b41413
Author: Nour Siwar @ Esri <100004210+NourdotSiwar@users.noreply.github.com>
Date:   Tue Aug 6 13:51:24 2024 -0700

    Show line of sight add copyright header (#231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenoid sorenoid sorenoid approved these changes

@kaushikrw kaushikrw kaushikrw approved these changes

Assignees

@shubham7109 shubham7109

Labels
New sample New Kotlin sample using ArcGIS Maps SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham7109 @sorenoid @kaushikrw