Migrate Edit and Sync Features with Feature Service to Compose #227
Conversation
…-feature-service-compose' into nour/edit-and-sync-features-with-feature-service-compose
There was a problem hiding this comment.
Nice one @NourdotSiwar! Hopped on a second review here since I saw it in the US board. Alot going on in this sample and you've made it really readable! See comments below. Thanks!
edit-and-sync-features-with-feature-service/README.metadata.json
Outdated
Show resolved
Hide resolved
.../java/com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Show resolved
Hide resolved
|
Ahh sorry @NourdotSiwar and @shubham7109 -- I meant to grab one of the ones in ready to review 2. Apologies! |
…nd private set keywords
There was a problem hiding this comment.
LGTM! Just one further comment in line.
Also, I think the screenshot needs updating. Good to remove the "For Developer Use Only" watermark. Lately I've been using a Pixel Fold emulator for screenshots. Resizing to a width of 700 pixels, and then cutting off the top of the map at 400 pixels height. That way I don't need to worry about cutting out the toolbar at the top with the title
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice work @NourdotSiwar! 🎉
I added some code quality changes, and noticed a screenshot placed in the wrong sample probably by accident. And added a comment to help optimize the usage of different coroutine dispatchers.
show-viewshed-from-point-in-scene/src/main/res/drawable/image.png
Outdated
Show resolved
Hide resolved
.../java/com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
.../java/com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
.../com/esri/arcgismaps/sample/editandsyncfeatureswithfeatureservice/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
edit-and-sync-features-with-feature-service/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
edit-and-sync-features-with-feature-service/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
…factored dispatcher code
shubham7109
deleted the
nour/edit-and-sync-features-with-feature-service-compose
branch
Description
PR to migrate an XML Kotlin sample "Edit and Sync Features with Feature Service to Compose" in
Edit and Manage Datacategory.Links and Data
Sample Epic:
runtime/kotlin/issues/ISSUE_NUMBERWhat To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.