Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyze hotspots #176

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

prupani-7
Copy link

Description

PR to revisit sample to reflect new changes in Kotlin toolkit.

Links and Data

Kotlin issue #3580

What To Review

  • Build and run the sample to check for any errors.
  • Remove MapViewpointOperation from MapView composable. Geo-compose: Remove ViewpointOperations arcgis-maps-sdk-kotlin-toolkit#316
  • Update the MapViewModel to be able to work with the geo-compose module.
  • Update Toolkit version.
  • Add the line to the "Additional information section": This sample uses the GeoCompose Toolkit module to be able to implement a Composable MapView.
  • Replace the application parameter from the MainScreen with the use of LocalContext.current.applicationContext
  • Add the tags: geocompose, tookit
  • Update the sample's metadata.json file to reflect file and tags changes

How to Test

Run the sample on the sample viewer or the repo.

@prupani-7 prupani-7 changed the title update sample update analyze hotspots Mar 6, 2024
@prupani-7 prupani-7 changed the title update analyze hotspots Update analyze hotspots Mar 6, 2024
Copy link

@ruiqima ruiqima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ruiqima
Copy link

ruiqima commented Mar 7, 2024

Could we update geoprocessingJobProgress.value to geoprocessingJobProgress.intValue in ViewModel class line 121 and 122?

@prupani-7
Copy link
Author

Could we update geoprocessingJobProgress.value to geoprocessingJobProgress.intValue in ViewModel class line 121 and 122?

I believe we can use intValue in place of value, as looking at the SnapshotIntState.kt file,
the interface MutableIntState represents a mutable integer state, and it gives access to an integer value through the value property, which looks like it internally corresponds to the intValue property.

@shubham7109 since you wrote you this implementation, are you okay with this change?

@shubham7109
Copy link
Collaborator

@ruiqima It seems like a welcomed change, @prupani-7 sure! let's add it in.

@prupani-7 prupani-7 merged commit b24cb02 into feature-branch/geo-compose Mar 8, 2024
1 check passed
@prupani-7 prupani-7 deleted the pri/update-analyze-hotspots branch March 8, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants