update atomicstore to 0.1.5 #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe and
sveitser
as code owners
imabdulbasit
force-pushed
the
ab/update-atomicstore-0-1-5
branch
from
43e1d8c to
a760e70
Compare
rob-maron
approved these changes
Feb 28, 2025
rob-maron
pushed a commit
that referenced
this pull request
Feb 28, 2025
sveitser
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Don't lock channels * cargo fix * Allow killing the connected network handler * Fix issues * Remove State from NetworkNodeHandle * Remove async where it's unused * fix async std build * Fix erros a little * Starting VID request response * handle network event * Bubble up request/response * Make Request and Response just bytes at network layer * Adding to ConnectedNetwork * Hooks for request/response in handle + trait * fix request * Remove request and response tasks for now * update mod.rs * Hooked up response flow to ConnectedNetwork * Refactor interface to return result to caller * Add request and response to message struct * Clean up some message stuff * Fix build error * Hook up request and response fully * Review myself, impl functions for combine * Change Receiver interface to spawn task * try_send instead of send * Create the task for request handling * rename request -> response * fix lint * clean up request response event handle fn * fix build * Comments and make the request signed * add signature checking * link gh issue * Add Event for Validated Quorum Proposal * Fix consensus task * fix upgrade test * start adding the task * Fix the test...again * progress * Finish request task, modify vid disperse event * Address comments * fix build * Make CombinedNetworks delay duration configurable * Secondary network delay configurable in HotShotConfig * Rename CombinedConfig to CombinedNetworkConfig * Network delay in test network generator `secondary_network_delay` removed from `HotShotConfig` because it cannot easily be passed to the test network generator. * lock * Temporary pinning to hotshot-types branch TODO: switch to hotshot-types tag or main branch before merging * fixes * Pin to hotshot-types tag 0.1.2 * Remove files added back by mistake * fix build * Remove whitespace * Review comments * fixes after main merge --------- Co-authored-by: Lukasz Rzasik <lukasz.rzasik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.