WIP: draft for stake table contract #2662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/src/StakeTable.sol
Outdated
| // @notice creates a pool and configure the initial fee | ||
| // TODO: docs | ||
| function createPool( | ||
| BN254.G2Point memory blsVK, |
There was a problem hiding this comment.
curious if hotshot is aware of the ethereum address of a validator and if so if it should be added here (since the address is meant to be the unique identifier and the bls key can change)
There was a problem hiding this comment.
It's currently assumed that it's msg.sender. I expect the confirmation layer to get it from the emitted event. Do you think we should do something different?
This is not a working implementation but intended to provide rust bindings that are equal or close to what we expect after implementation is done.
sveitser
force-pushed
the
ma/stake-table-contract-delegation
branch
from
b5b26f5 to
6475d00
Compare
sveitser
changed the title
This is draft and there are no tests yet.
We are already checking a signature from the BLS key. Due to pre-image resistance we don't need to check if the key is zero.
- Some of the tests do not apply anymore since the requirements changed. Notably anything relating to the queue logic for entering and exiting. - Fix that we were not crediting delegations. - Update undelegation test to test partial withdrawals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a working implementation but intended to provide rust
bindings that are equal or close to what we expect after implementation
is done.
cc @imabdulbasit